Skip to content

fix: stricter boolean prop guessing#212

Merged
farnabaz merged 1 commit into
mainfrom
fix/stream-bool
May 22, 2026
Merged

fix: stricter boolean prop guessing#212
farnabaz merged 1 commit into
mainfrom
fix/stream-bool

Conversation

@atinux
Copy link
Copy Markdown
Contributor

@atinux atinux commented May 22, 2026

This should fix the error on landing page when streaming and icon prop is wrongly considered as boolean for the ::callout

The 'true' is added before to we can have a stricter check here

@atinux atinux requested a review from farnabaz May 22, 2026 10:37
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comark Ready Ready Preview May 22, 2026 10:44am
comark-json-render Ready Ready Preview May 22, 2026 10:44am
comark-nextjs Ready Ready Preview May 22, 2026 10:44am
comark-nuxt Ready Ready Preview May 22, 2026 10:44am
comark-svelte Ready Ready Preview May 22, 2026 10:44am
comark-sveltekit Ready Ready Preview May 22, 2026 10:44am
comark-twoslash Ready Ready Preview May 22, 2026 10:44am
comark-vue Ready Ready Preview May 22, 2026 10:44am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 22, 2026

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@212

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@212

@comark/html

npm i https://pkg.pr.new/@comark/html@212

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@212

@comark/react

npm i https://pkg.pr.new/@comark/react@212

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@212

@comark/vue

npm i https://pkg.pr.new/@comark/vue@212

commit: 38aa0fc

Copy link
Copy Markdown
Contributor

@larbish larbish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look legit ✅

@farnabaz farnabaz merged commit 34f75a5 into main May 22, 2026
11 checks passed
@farnabaz farnabaz deleted the fix/stream-bool branch May 22, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants