Skip to content

fix: reduce Secret Manager costs by resolving secrets at deploy time #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rozen03 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reduce Secret Manager costs by resolving secrets at deploy time #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 40 additions & 15 deletions .github/workflows/google-cloudrun-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,24 +72,37 @@ jobs:
id: get_url
run: echo "URL=$(gcloud run services describe ${{ env.SERVICE_NAME }} --platform managed --region ${{ env.PROJECT_REGION }} --format 'value(status.url)')" >> $GITHUB_ENV

- name: Get Secrets from Secret Manager
id: secrets
uses: 'google-github-actions/get-secretmanager-secrets@v2'
with:
secrets: |-
TELEGRAM_BOT_TOKEN:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_TG_BOT_TOKEN }}
DB_USER:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_USER }}
DB_PASSWORD:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_PASSWORD }}
DB_URL:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_URL }}
S3_ACCESS_ID:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_S3_ACCESS_ID }}
S3_ACCESS_SECRET:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_S3_ACCESS_SECRET }}
S3_HOST:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_S3_HOST }}

- name: Deploy to Cloud Run
env:
TELEGRAM_BOT_TOKEN: ${{ steps.secrets.outputs.TELEGRAM_BOT_TOKEN }}
DB_USER: ${{ steps.secrets.outputs.DB_USER }}
DB_PASSWORD: ${{ steps.secrets.outputs.DB_PASSWORD }}
DB_URL: ${{ steps.secrets.outputs.DB_URL }}
S3_ACCESS_ID: ${{ steps.secrets.outputs.S3_ACCESS_ID }}
S3_ACCESS_SECRET: ${{ steps.secrets.outputs.S3_ACCESS_SECRET }}
S3_HOST: ${{ steps.secrets.outputs.S3_HOST }}
run: |-
gcloud run deploy ${{ env.SERVICE_NAME }} \
--image $TAG \
--region ${{ env.PROJECT_REGION }} \
--service-account ${{ vars.GCP_SA_EMAIL }} \
--memory=256Mi \
--max-instances=${{ vars.GCP_SERVICE_API_MAX_INSTANCES }} \
--set-secrets=TELEGRAM_BOT_TOKEN=${{ vars.GCP_SECRET_TG_BOT_TOKEN }}:latest \
--set-secrets=DB_USER=${{ vars.GCP_SECRET_DB_USER }}:latest \
--set-secrets=DB_PASSWORD=${{ vars.GCP_SECRET_DB_PASSWORD }}:latest \
--set-secrets=DB_URL=${{ vars.GCP_SECRET_DB_URL }}:latest \
--set-env-vars=DB_PORT=${{ vars.GCP_DB_PORT }} \
--set-secrets=S3_ACCESS_ID=${{ vars.GCP_SECRET_S3_ACCESS_ID }}:latest \
--set-secrets=S3_ACCESS_SECRET=${{ vars.GCP_SECRET_S3_ACCESS_SECRET }}:latest \
--set-secrets=S3_HOST=${{ vars.GCP_SECRET_S3_HOST }}:latest \
--set-env-vars=S3_BUCKET=${{ vars.GCP_S3_BUCKET }} \
--set-env-vars=WEBHOOK_URL=${{ env.URL }} \
--clear-secrets \
--set-env-vars "^@^TELEGRAM_BOT_TOKEN=$TELEGRAM_BOT_TOKEN@DB_USER=$DB_USER@DB_PASSWORD=$DB_PASSWORD@DB_URL=$DB_URL@DB_PORT=${{ vars.GCP_DB_PORT }}@S3_ACCESS_ID=$S3_ACCESS_ID@S3_ACCESS_SECRET=$S3_ACCESS_SECRET@S3_HOST=$S3_HOST@S3_BUCKET=${{ vars.GCP_S3_BUCKET }}@WEBHOOK_URL=${{ env.URL }}" \
--platform managed \
--allow-unauthenticated

Expand All @@ -115,19 +128,31 @@ jobs:
- name: Define image tag for deployment
run: echo "TAG=${{ env.PROJECT_REGION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.ARTIFACT_REGISTRY }}/${{ env.SERVICE_NAME }}:${{ github.sha }}" >> $GITHUB_ENV

- name: Get Secrets from Secret Manager
id: secrets
uses: 'google-github-actions/get-secretmanager-secrets@v2'
with:
secrets: |-
TELEGRAM_BOT_TOKEN:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_TG_BOT_TOKEN }}
DB_USER:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_USER }}
DB_PASSWORD:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_PASSWORD }}
DB_URL:${{ env.PROJECT_ID }}/${{ vars.GCP_SECRET_DB_URL }}

- name: Deploy Cloud Run Job
env:
TELEGRAM_BOT_TOKEN: ${{ steps.secrets.outputs.TELEGRAM_BOT_TOKEN }}
DB_USER: ${{ steps.secrets.outputs.DB_USER }}
DB_PASSWORD: ${{ steps.secrets.outputs.DB_PASSWORD }}
DB_URL: ${{ steps.secrets.outputs.DB_URL }}
run: |-
gcloud run jobs deploy ${{ env.JOB_NAME }} \
--image $TAG \
--region ${{ env.PROJECT_REGION }} \
--command=python \
--args=cron.py \
--service-account ${{ vars.GCP_SA_EMAIL }} \
--set-secrets=TELEGRAM_BOT_TOKEN=${{ vars.GCP_SECRET_TG_BOT_TOKEN }}:latest \
--set-secrets=DB_USER=${{ vars.GCP_SECRET_DB_USER }}:latest \
--set-secrets=DB_PASSWORD=${{ vars.GCP_SECRET_DB_PASSWORD }}:latest \
--set-secrets=DB_URL=${{ vars.GCP_SECRET_DB_URL }}:latest \
--set-env-vars=DB_PORT=${{ vars.GCP_DB_PORT }}
--clear-secrets \
--set-env-vars "^@^TELEGRAM_BOT_TOKEN=$TELEGRAM_BOT_TOKEN@DB_USER=$DB_USER@DB_PASSWORD=$DB_PASSWORD@DB_URL=$DB_URL@DB_PORT=${{ vars.GCP_DB_PORT }}"

- name: Create or Update Cloud Scheduler Job
run: |
Expand Down