Skip to content

fix(frontend): scope logs existence probes by time range#7300

Closed
Levi-Wu-777 wants to merge 1 commit into
comet-ml:mainfrom
paperboytm:paperboy/fix-metrics-time-range
Closed

fix(frontend): scope logs existence probes by time range#7300
Levi-Wu-777 wants to merge 1 commit into
comet-ml:mainfrom
paperboytm:paperboy/fix-metrics-time-range

Conversation

@Levi-Wu-777

Copy link
Copy Markdown

Summary

This updates the Logs page SDK existence probes to use the currently selected time range.

The traces/spans tab already applies fromTime / toTime to the main table, stats, and CSV export queries, but its size=1 existence probe did not include those fields. The threads tab had the same gap. On large projects, those probes can scan all historical SDK traces/threads even when the user is looking at a bounded range such as past 24 hours.

Fixes #7298.

Changes

  • Pass fromTime: intervalStart and toTime: intervalEnd to the traces/spans SDK existence probe.
  • Pass fromTime: intervalStart and toTime: intervalEnd to the threads SDK existence probe.

Testing

  • cd apps/opik-frontend && npm ci
  • cd apps/opik-frontend && npm run typecheck
  • cd apps/opik-frontend && npm run lint

@Levi-Wu-777
Levi-Wu-777 requested a review from a team as a code owner July 1, 2026 08:47
@andrescrz

Copy link
Copy Markdown
Member

Hi @Levi-Hope

Thanks a lot for taking the time to put this together and contribute to the project—we really appreciate it.

We're going to close this PR for now. We actually tried a very similar approach in the past, but ended up having to revert it because it introduced more performance issues.

The good news is that we already have a different solution that's nearly ready to merge and addresses the same underlying problem: #7378.

Thanks again for the contribution and for helping improve Opik. Even though we won't be moving forward with this particular change, we really appreciate your effort and hope you'll continue contributing in the future.

@andrescrz andrescrz closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MetricsTab trace existence probe omits time range and causes full project scan

2 participants