fix(frontend): scope logs existence probes by time range#7300
Closed
Levi-Wu-777 wants to merge 1 commit into
Closed
fix(frontend): scope logs existence probes by time range#7300Levi-Wu-777 wants to merge 1 commit into
Levi-Wu-777 wants to merge 1 commit into
Conversation
Member
|
Hi @Levi-Hope Thanks a lot for taking the time to put this together and contribute to the project—we really appreciate it. We're going to close this PR for now. We actually tried a very similar approach in the past, but ended up having to revert it because it introduced more performance issues. The good news is that we already have a different solution that's nearly ready to merge and addresses the same underlying problem: #7378. Thanks again for the contribution and for helping improve Opik. Even though we won't be moving forward with this particular change, we really appreciate your effort and hope you'll continue contributing in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Logs page SDK existence probes to use the currently selected time range.
The traces/spans tab already applies
fromTime/toTimeto the main table, stats, and CSV export queries, but itssize=1existence probe did not include those fields. The threads tab had the same gap. On large projects, those probes can scan all historical SDK traces/threads even when the user is looking at a bounded range such as past 24 hours.Fixes #7298.
Changes
fromTime: intervalStartandtoTime: intervalEndto the traces/spans SDK existence probe.fromTime: intervalStartandtoTime: intervalEndto the threads SDK existence probe.Testing
cd apps/opik-frontend && npm cicd apps/opik-frontend && npm run typecheckcd apps/opik-frontend && npm run lint