use node builtin promises and node >=14 supported

Author: Comick

.github/workflows/test.js.yml

@@ -16,7 +16,8 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x, 18.x, 19.x]
+        # Kept current with https://github.com/nodejs/release#release-schedule
+        node-version: [14.x, 16.x, 18.x, 19.x]
         robot-version: [3.2.2, 4.1.3, 5.0, 6.0.1]
     steps:
     - uses: actions/checkout@v3

bin/botclient.js

@@ -8,11 +8,11 @@ var robot = require('../lib/robotremote'),
 var options = {host: process.argv[2] || 'localhost', port: parseInt(process.argv[3], 10) || 8270};
 var serverString = options.host + ':' + options.port;
 
-robot.createClient(options).then(function (keywords) {
+robot.createClient(options).then(keywords -> {
     console.log('Connected to remote server at "' + serverString + '"');
     console.log('Available keywords: ' + Object.keys(keywords).join(', '));
     repl.start(serverString + '> ').context.keywords = keywords;
-}, function (err) {
+}, err -> {
     console.log('Could not connected to remote server at "' + serverString + '"');
     throw err;
 });

lib/robotremote.js

@@ -163,7 +163,7 @@ Server.prototype.runKeyword = function (name, params, response) {
         keywordReturn(e);
         return;
     }
-    if (isPromise(result)) {
+    if (util.types.isPromise(result)) {
         result.then(keywordReturn, keywordReturn);
     } else {
         // Got sync keyword return.
@@ -199,7 +199,6 @@ function KeywordLogger(writeOutput) {
  * @constructor
  */
 function createClient(options) {
-    var Promise = require('promise');
     var result = new Promise(function (resolve, reject) {
         //options.path = '/';
         var client = xmlrpc.createClient(options);
@@ -239,30 +238,4 @@ function createClient(options) {
     return result;
 }
 
-/**
- * isPromise is Copyright (c) 2014 Forbes Lindesay
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- * THE SOFTWARE.
- *
- */
-function isPromise(obj) {
-    return !!obj && (typeof obj === 'object' || typeof obj === 'function') && typeof obj.then === 'function';
-}
-
 module.exports.createClient = createClient;

package.json

@@ -11,7 +11,7 @@
         "test",
         "ATDD"
     ],
-    "version": "1.4.1",
+    "version": "1.5.0",
     "preferGlobal": false,
     "homepage": "https://github.com/comick/node-robotremoteserver",
     "author": {
@@ -33,8 +33,7 @@
     },
     "main": "./lib/robotremote.js",
     "dependencies": {
-        "xmlrpc": ">=1.3.2",
-        "promise": ">=8.1.0"
+        "xmlrpc": ">=1.3.2"
     },
     "devDependencies": {
         "mocha": ">=8.0.1"
@@ -43,7 +42,7 @@
         "test": "mocha && (pybot test || robot test)"
     },
     "engines": {
-        "node": ">=0.10",
+        "node": ">=14.0",
         "npm": ">=1.4.0"
     },
     "licenses": [

test/test.js

@@ -26,7 +26,7 @@ describe('Robot Remote Library', function () {
     it('client should fail to start if server is not running', function (done) {
         // In case of slow DNS this will fail after 2000ms
         this.timeout(5000); 
-        robot.createClient({host: 'localhost', port: nextPort()}).done(
+        robot.createClient({host: 'localhost', port: nextPort()}).then(
             function (val) {
                 throw new Error('client succeeded');
             },
@@ -38,7 +38,7 @@ describe('Robot Remote Library', function () {
     it('client should start and list all keywords when server is running', function (done) {
         var serverPort = nextPort();
         server = new robot.Server([testLibrary], {host: 'localhost', port: serverPort, allowStop: true}, function () {
-            robot.createClient({host: 'localhost', port: serverPort}).done(
+            robot.createClient({host: 'localhost', port: serverPort}).then(
                 function (val) {
                     keywordsEqual(val, server.keywords);
                     done();
@@ -65,9 +65,9 @@ describe('Robot Remote Library', function () {
             {testKeyword: testKeyword}
         ];
         server = new robot.Server(libraries, {host: 'localhost', port: serverPort, allowStop: true}, function () {
-            robot.createClient({host: 'localhost', port: serverPort}).done(
+            robot.createClient({host: 'localhost', port: serverPort}).then(
                 function (clientKeywords) {
-                    clientKeywords.testKeyword('param').done(function (val) {
+                    clientKeywords.testKeyword('param').then(function (val) {
                     });
                 }, done
             );
@@ -87,9 +87,9 @@ describe('Robot Remote Library', function () {
             }
         };
         server = new robot.Server([lib], {host: 'localhost', port: serverPort, allowStop: true}, function () {
-            robot.createClient({host: 'localhost', port: serverPort}).done(
+            robot.createClient({host: 'localhost', port: serverPort}).then(
                 function (val) {
-                    val.testKeyword('param').done(function (res) {
+                    val.testKeyword('param').then(function (res) {
                         assert.deepEqual(res, {
                             output: util.format('*WARN:%d* message\n*TRACE:%d* message\n*DEBUG:%d* message\n*INFO:%d* message\n*HTML:%d* message\n', twarn, ttrace, tdebug, tinfo, thtml),
                             status: 'PASS',
@@ -111,9 +111,9 @@ describe('Robot Remote Library', function () {
             }
         };
         server = new robot.Server([lib], {host: 'localhost', port: serverPort, allowStop: true}, function () {
-            robot.createClient({host: 'localhost', port: serverPort}).done(
+            robot.createClient({host: 'localhost', port: serverPort}).then(
                 function (val) {
-                    val.testKeyword().done(done, function (err) {
+                    val.testKeyword().then(done, function (err) {
                         assert.equal(true, err.continuable);
                         assert.equal(true, err.fatal);
                         done();
@@ -135,11 +135,11 @@ describe('Robot Remote Library', function () {
             }
         };
         server = new robot.Server([lib1, lib2], {host: 'localhost', port: serverPort, allowStop: true}, function () {
-            robot.createClient({host: 'localhost', port: serverPort}).done(
+            robot.createClient({host: 'localhost', port: serverPort}).then(
                 function (val) {
-                    val.testKeywordFromLib1().done(function () {
+                    val.testKeywordFromLib1().then(function () {
                     }, done);
-                    val.testKeywordFromLib2().done(function (val) {
+                    val.testKeywordFromLib2().then(function (val) {
                         done();
                     }, done);
                 }, done

test/testlibrary.js

@@ -1,7 +1,6 @@
 'use strict';
 
-var assert = require('assert'),
-    Promise = require('promise');
+var assert = require('assert');
 
 var lib = module.exports;