enable biome lint, try 2 (#576)

* config and --fix

* unsafe fixes

* rest of em

Author: adeebshihadeh

biome.json

@@ -1,9 +1,7 @@
 {
   "root": true,
   "files": {
-    "includes": [
-      "src/**/*"
-    ]
+    "includes": ["src/**/*"]
   },
   "formatter": {
     "indentStyle": "space",
@@ -17,9 +15,32 @@
       "semicolons": "always",
       "trailingCommas": "all"
     },
-    "globals": [
-      "jestPuppeteer",
-      "page"
-    ]
-  }
+    "globals": ["gtag", "jestPuppeteer", "page", "jest", "describe", "it", "beforeAll", "afterAll", "beforeEach", "afterEach", "expect", "test", "AppleID"]
+  },
+  "linter": {
+    "rules": {
+      "recommended": false,
+      "correctness": "warn",
+      "style": "off",
+      "suspicious": "off",
+      "security": "off",
+      "performance": "off",
+      "complexity": "off",
+      "nursery": "off",
+      "a11y": "off"
+    }
+  },
+  "overrides": [
+    {
+      "includes": ["**/*.jsx", "**/*.tsx"],
+      "linter": {
+        "rules": {
+          "correctness": {
+            "noSolidDestructuredProps": "off",
+            "noNestedComponentDefinitions": "off"
+          }
+        }
+      }
+    }
+  ]
 }

package.json

@@ -6,7 +6,7 @@
     "build:development": "env-cmd .env.development vite build --mode development",
     "build:production": "vite build",
     "serve": "vite preview",
-    "lint": "printf 'biome lint currently disabled; fix required first\n'",
+    "lint": "biome lint src",
     "format": "biome format --write src",
     "test": "jest",
     "test-coverage": "jest --coverage",

src/App.jsx

@@ -1,4 +1,4 @@
-import React, { Component, lazy, Suspense } from 'react';
+import { Component, lazy, Suspense } from 'react';
 import { Provider } from 'react-redux';
 import { Route, Switch, Redirect } from 'react-router';
 import { ConnectedRouter } from 'connected-react-router';
@@ -11,13 +11,13 @@ import { CircularProgress, Grid } from '@material-ui/core';
 import MyCommaAuth, { config as AuthConfig, storage as AuthStorage } from '@commaai/my-comma-auth';
 import { athena as Athena, auth as Auth, billing as Billing, request as Request } from '@commaai/api';
 
-import { getZoom, getSegmentRange } from './url';
-import store, { history } from './store';
+import { getZoom, getSegmentRange } from './url.js';
+import store, { history } from './store.js';
 
-import ErrorFallback from './components/ErrorFallback';
+import ErrorFallback from './components/ErrorFallback.jsx';
 
-const Explorer = lazy(() => import('./components/explorer'));
-const AnonymousLanding = lazy(() => import('./components/anonymous'));
+const Explorer = lazy(() => import('./components/explorer.jsx'));
+const AnonymousLanding = lazy(() => import('./components/anonymous.jsx'));
 
 class App extends Component {
   constructor(props) {

src/__puppeteer__/demo.test.js

@@ -1,5 +1,5 @@
 /* eslint-env jest */
-import { configureViewport, goto } from './utils';
+import { configureViewport, goto } from './utils.js';
 
 jest.setTimeout(30000);
 

src/__puppeteer__/drive.test.js

@@ -1,5 +1,5 @@
 /* eslint-env jest */
-import { configureViewport, goto } from './utils';
+import { configureViewport, goto } from './utils.js';
 
 const DEMO_DEVICE_URL = '/1d3dc3e03047b0c7';
 const DEMO_ROUTE_URL = '/1d3dc3e03047b0c7/000000dd--455f14369d';

src/__puppeteer__/jest.config.js

@@ -1,4 +1,4 @@
-const jestConfig = require('../../jest.config');
+const jestConfig = require('../../jest.config.js');
 
 delete jestConfig.testEnvironment;
 

src/__puppeteer__/routing.test.js

@@ -1,5 +1,5 @@
 /* eslint-env jest */
-import { configureViewport, goto } from './utils';
+import { configureViewport, goto } from './utils.js';
 
 jest.setTimeout(30000);
 

src/__tests__/App.test.jsx

@@ -1,7 +1,6 @@
-/* eslint-env jest */
-import React from 'react';
+
 import { act, render } from '@testing-library/react';
-import App from '../App';
+import App from '../App.jsx';
 
 describe('App', () => {
   it('should not crash', () => {

src/actions/cached.js

@@ -1,8 +1,8 @@
 import * as Sentry from '@sentry/react';
 
-import * as Types from './types';
-import { reverseLookup } from '../utils/geocode';
-import { toBool } from '../utils';
+import * as Types from './types.js';
+import { reverseLookup } from '../utils/geocode.js';
+import { toBool } from '../utils/index.js';
 
 const USE_LOCAL_COORDS_DATA = toBool(import.meta.env.VITE_APP_LOCAL_COORDS_DATA);
 if (USE_LOCAL_COORDS_DATA) {
@@ -415,7 +415,7 @@ export function fetchCoord(route, coord, locationKey) {
 }
 
 export function fetchLocations(route) {
-  return (dispatch, getState) => {
+  return (dispatch, _getState) => {
     dispatch(fetchCoord(route, [route.start_lng, route.start_lat], 'startLocation'));
     dispatch(fetchCoord(route, [route.end_lng, route.end_lat], 'endLocation'));
   };

src/actions/files.js

@@ -1,9 +1,9 @@
 import * as Sentry from '@sentry/react';
 import { athena as Athena, devices as Devices, raw as Raw } from '@commaai/api';
 
-import { updateDeviceOnline, fetchDeviceNetworkStatus } from '.';
-import * as Types from './types';
-import { deviceOnCellular, getDeviceFromState, deviceVersionAtLeast, asyncSleep } from '../utils';
+import { updateDeviceOnline, fetchDeviceNetworkStatus } from './index.js';
+import * as Types from './types.js';
+import { deviceOnCellular, getDeviceFromState, deviceVersionAtLeast, asyncSleep } from '../utils/index.js';
 
 export const FILE_NAMES = {
   qcameras: ['qcamera.ts'],
@@ -54,7 +54,7 @@ async function athenaCall(dongleId, payload, sentryFingerprint, retryCount = 0)
 }
 
 export function setRouteViewed(dongleId, route) {
-  return async (dispatch, getState) => {
+  return async (_dispatch, getState) => {
     const { device } = getState();
     if (!deviceVersionAtLeast(device, '0.9.6')) {
       return;