fix: re-enable Try the demo button#644
Closed
athospy wants to merge 1 commit into
Closed
Conversation
|
Welcome to connect! Make sure to:
deployed preview: https://644.connect-d5y.pages.dev |
The demo button was hidden in commaai#578 because the JWT token kept expiring and required manual rotation. The token was subsequently updated with a far-future expiry (year 2299) in commit da834ce, which removes the need for manual rotation going forward. The demo account is working and provides a useful way for contributors without a comma device to explore and test the app locally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
athospy
force-pushed
the
fix/re-enable-demo-button
branch
from
c1cb2d8 to
79209d8
Compare
Contributor
|
unfortunately, we removed demo mode for now, but we may add it back in the future. thanks for your PR though, we appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Try the demo" button was hidden in #578 (
disable demo for now). The likelyroot cause was the JWT token expiring repeatedly, requiring manual rotation.
The token was subsequently updated with a far-future expiry in commit
da834ce("one more time"), eliminating the need for manual rotation going forward.
The demo account is active and the experience works end-to-end: login, dashboard,
drive list, and map view all function correctly — useful for contributors without
a comma device, as mentioned in the README.
PR #586 noted this as a "separate bug, left for follow-up."