Branch switcher for Comma four#37739
Conversation
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
UI Previewmici: |
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
There was a problem hiding this comment.
I think we might want a software subsection, and use scrolling list of branches like 3X (horizontally), but maybe for later unless @nickorie wants now
There was a problem hiding this comment.
i definitely just want to ship the full thing instead of this. do we have all the ui primitives in place now to make this super easy?
There was a problem hiding this comment.
Im not familiar enough with the typical user flows for branch switching to make a determination right now of what the best format for the c4 should be. That being said, the only new element this seems like it might need (later) is an icon; otherwise buttons, scrolling text, keyboard, etc. should all be in there between the regular scrollers and the wifi scroller.
|
Missing logic from three (like |
|
BTW you don't need to reclone to switch branches from https://stackoverflow.com/questions/6802145/how-to-convert-a-git-shallow-clone-to-a-full-clone |
|
Thanks for the PR, moving it here: #37894 |
4 participants
Adding a branch switcher for C4.
Without it, drivers have to do full uninstall/reinstall, Requiring long downloads for even a 1-commit difference, and requiring the DM headshakes every time.
Widely used as this is now in all my C4 Honda forks.
Chose to make it a typed branch name, rather than a scroller like C3X, because the C4 scroller templates are horizontal and would take a very long time.
Flow:
Settings -> device -> switch branch -> type in new branch -> enter -> then update