small app refactor, fix fail test output, add docs and changlog entry

Author: dylanhitt

CHANGELOG.md

@@ -1,3 +1,7 @@
+# v2.1.0
+ 
+  - Added `--dir` flag to execute all commander test suites within a directory. This feature is not recursive.
+
 # v2.0.0
 
   - Added `nodes` which allow remote execution of tests

README.md

@@ -195,6 +195,9 @@ $ ./commander test /tmp/test.yaml
 
 # Execute a single test
 $ ./commander test /tmp/test.yaml "my test"
+
+# Execute suites within a test directory
+$ ./commander test --dir /tmp
 ```
 
 ### Adding tests

cmd/commander/commander.go

@@ -61,7 +61,7 @@ func createTestCommand() cli.Command {
 			},
 			cli.BoolFlag{
 				Name:  "dir",
-				Usage: "Execute all test files in directory - e.g. /path/to/test_files/",
+				Usage: "Execute all test files in a directory sorted by file name, this is not recursive - e.g. /path/to/test_files/",
 			},
 		},
 		Action: func(c *cli.Context) error {

integration/unix/directory_test/place_holder/test

@@ -1,4 +1,4 @@
 Hello, I am file in a directory. Don't delete me
 as I am a place hold for commander's integration tests.
-Please see missing test 'test missing dir flag' in
+Please see the test 'test missing dir flag' in
 commander_unix.yaml for why (:

pkg/app/test_command.go

@@ -5,6 +5,7 @@ import (
 	"io/ioutil"
 	"log"
 	"os"
+	"path"
 	"sync"
 
 	"github.com/SimonBaeumer/commander/pkg/output"
@@ -71,7 +72,7 @@ func testDir(directory string) (<-chan runtime.TestResult, error) {
 				continue
 			}
 
-			fileResults, err := testFile(directory+"/"+f.Name(), "")
+			fileResults, err := testFile(path.Join(directory, f.Name()), "")
 			if err != nil {
 				panic(fmt.Sprintf("%s: %s", f.Name(), err))
 			}

pkg/output/cli.go

@@ -42,9 +42,9 @@ func (w *OutputWriter) Start(results <-chan runtime.TestResult) bool {
 	for r := range results {
 		testResults = append(testResults, r)
 		if r.ValidationResult.Success {
-			w.printResult(r, "✓")
+			w.printResult(r)
 		} else {
-			w.printResult(r, "✗")
+			w.printResult(r)
 			failed++
 		}
 	}
@@ -67,8 +67,15 @@ func (w *OutputWriter) Start(results <-chan runtime.TestResult) bool {
 	return failed == 0
 }
 
-func (w *OutputWriter) printResult(r runtime.TestResult, mark string) {
-	str := fmt.Sprintf("%s [%s] %s", mark, r.Node, r.TestCase.Title)
+func (w *OutputWriter) printResult(r runtime.TestResult) {
+	if !r.ValidationResult.Success {
+		str := fmt.Sprintf("✗ [%s] %s", r.Node, r.TestCase.Title)
+		str = w.addFile(str, r)
+		s := w.addTries(str, r)
+		w.fprintf(au.Red(s))
+		return
+	}
+	str := fmt.Sprintf("✓ [%s] %s", r.Node, r.TestCase.Title)
 	str = w.addFile(str, r)
 	s := w.addTries(str, r)
 	w.fprintf(s)