Add better errors for ssh

Author: SimonBaeumer

commander_unix.yaml

@@ -71,5 +71,8 @@ tests:
     stdout:
       contains:
         - ✓ [ssh-host] it should test ssh host
+        - ✓ [ssh-host] it should set env variable
         - ✗ [local] it should test ssh host
+        - ✗ [ssh-host] it should fail if env could not be set
+        - "Failed setting env variables, maybe ssh server is configured to only accept LC_ prefixed env variables. Error: ssh: setenv failed"
     exit-code: 1

integration/unix/nodes.yaml

@@ -16,4 +16,22 @@ tests:
         - test file ssh
         - root
         - /root
-    exit-code: 0
+    exit-code: 0
+
+  it should set env variable:
+    nodes:
+      - ssh-host
+    config:
+      env:
+        LC_TEST_ENV: env var
+    command: echo $LC_TEST_ENV
+    stdout: env var
+
+  it should fail if env could not be set:
+    nodes:
+      - ssh-host
+    config:
+      env:
+        TEST_ENV: env var
+    command: echo $TEST_ENV
+    stdout: env var

pkg/output/cli.go

@@ -45,13 +45,15 @@ func (w *OutputWriter) Start(results <-chan runtime.TestResult) bool {
 			str := fmt.Sprintf("✓ [%s] %s", r.Node, r.TestCase.Title)
 			s := w.addTries(str, r)
 			w.fprintf(s)
+			continue
 		}
 
 		if !r.ValidationResult.Success {
 			failed++
 			str := fmt.Sprintf("✗ [%s] %s", r.Node, r.TestCase.Title)
 			s := w.addTries(str, r)
 			w.fprintf(au.Red(s))
+			continue
 		}
 	}
 

pkg/runtime/runtime.go

@@ -125,6 +125,7 @@ type TestResult struct {
 	FailedProperty   string
 	Tries            int
 	Node             string
+	Error            error
 }
 
 // Start starts the given test suite and executes all tests

pkg/runtime/ssh_executor.go

@@ -21,7 +21,7 @@ type SSHExecutor struct {
 // Execute executes a command on a remote host viá SSH
 func (e SSHExecutor) Execute(test TestCase) TestResult {
 	if test.Command.InheritEnv {
-		log.Fatal("Inherit env is not supported viá SSH")
+		panic("Inherit env is not supported viá SSH")
 	}
 
 	// initialize auth methods with pass auth method as the default
@@ -65,7 +65,12 @@ func (e SSHExecutor) Execute(test TestCase) TestResult {
 	for k, v := range test.Command.Env {
 		err := session.Setenv(k, v)
 		if err != nil {
-			log.Fatal(fmt.Sprintf("Failed, maybe ssh server is configured to only accept LC_ prefixed env variables. Error: %s", err))
+			test.Result = CommandResult{
+				Error: fmt.Errorf("Failed setting env variables, maybe ssh server is configured to only accept LC_ prefixed env variables. Error: %s", err),
+			}
+			return TestResult{
+				TestCase: test,
+			}
 		}
 	}