add separate integration test for testing stdin

Author: dylanhitt

cmd/commander/commander.go

@@ -54,7 +54,7 @@ Tests are always executed in alphabetical order.
 Examples:
 
 Directory test:
-commander test --dir /your/dir/
+test --dir /your/dir/
 
 Stdin test:
 cat commander.yaml | commander test -

commander_linux.yaml

@@ -38,18 +38,3 @@ tests:
       contains:
         - Use --dir to test directories with multiple test files
     exit-code: 1
-
-  test nodes with stdin:
-    command: cat integration/linux/nodes.yaml | ./commander test -
-    stdout:
-      contains:
-        - ✓ [ssh-host] it should test ssh host
-        - ✓ [ssh-host] it should set env variable
-        - ✓ [ssh-host-default] it should be executed on ssh-host-default
-        - "- [ssh-host-default] it should skip, was skipped" 
-        - "- [ssh-host] it should skip, was skipped" 
-        - "- [local] it should skip, was skipped" 
-        - ✓ [ssh-host] it should test multiple hosts
-        - ✓ [ssh-host-default] it should test multiple hosts
-        - ✓ [local] it should test multiple hosts
-    exit-code: 0

commander_unix.yaml

@@ -134,11 +134,9 @@ tests:
         - ✓ [local] hello world
     exit-code: 0
 
-  test retries with stdin:
-    command: cat integration/unix/retries.yaml | ./commander test -
+  test stdin input:
+    command: cat integration/unix/stdin.yaml | ./commander test -
     stdout:
       contains:
-        - ✗ [local] echo hello, retries 3
-        - ✓ [local] it should retry failed commands, retries 2
-        - ✗ [local] it should retry failed commands with an interval, retries 2
-    exit-code: 1
+        - ✓ [local] hello world
+    exit-code: 0

commander_windows.yaml

@@ -64,9 +64,9 @@ tests:
         - ✗ [local] echo hello, retries 3
     exit-code: 1
 
-  test retries with stdin:
-    command: type integration\windows\retries.yaml | commander.exe test -
+  test stdin input:
+    command: type integration\windows\stdin.yaml | commander.exe test -
     stdout:
       contains:
-        - ✗ [local] echo hello, retries 3
-    exit-code: 1
+        - ✓ [local] hello world
+    exit-code: 0

integration/unix/stdin.yaml

@@ -0,0 +1,5 @@
+tests:
+  hello world:
+    command: echo hello world
+    stdout: hello world
+    exit-code: 0

integration/windows/stdin.yaml

@@ -0,0 +1,5 @@
+tests:
+  hello world:
+    command: echo hello world
+    stdout: hello world
+    exit-code: 0

pkg/app/test_command.go

@@ -132,7 +132,7 @@ func testStdin(filters runtime.Filters) (runtime.Result, error) {
 		return runtime.Result{}, err
 	}
 
-	if f.Mode()&os.ModeCharDevice != 0 {
+	if (f.Mode() & os.ModeCharDevice) != 0 {
 		return runtime.Result{}, fmt.Errorf("Error: when testing from stdin the command is intended to work with pipes")
 	}
 

pkg/app/test_command_test.go

@@ -102,11 +102,7 @@ tests:
 func Test_TestCommand_Http_Err(t *testing.T) {
 	err := TestCommand("http://error/not/a/url", TestCommandContext{Dir: false})
 
-	if runtime.GOOS == "windows" {
-		assert.NotNil(t, err)
-	} else {
-		assert.NotNil(t, err)
-	}
+	assert.NotNil(t, err)
 }
 
 func Test_TestCommand_StdIn(t *testing.T) {
@@ -154,11 +150,7 @@ func Test_TestCommand_StdIn_Err(t *testing.T) {
 
 	err := TestCommand("-", TestCommandContext{Verbose: false})
 
-	if runtime.GOOS == "windows" {
-		assert.NotNil(t, err)
-	} else {
-		assert.NotNil(t, err)
-	}
+	assert.NotNil(t, err)
 }
 
 func Test_ConvergeResults(t *testing.T) {