Add suite tests

Author: SimonBaeumer

pkg/runtime/runtime.go

@@ -72,7 +72,6 @@ type TestConfig struct {
 	Retries    int
 	Interval   string
 	InheritEnv bool
-	SSH        SSHExecutor
 }
 
 // ResultStatus represents the status code of a test result

pkg/suite/suite.go

@@ -12,13 +12,6 @@ type Suite struct {
 	Nodes     []runtime.Node
 }
 
-func NewSuite(config runtime.TestConfig, tests ...runtime.TestCase) *Suite {
-	return &Suite{
-		TestCases: tests,
-		Config:    config,
-	}
-}
-
 func (s Suite) GetNodes() []runtime.Node {
 	return s.Nodes
 }
@@ -33,7 +26,7 @@ func (s Suite) GetNodeByName(name string) (runtime.Node, error) {
 }
 
 func (s Suite) AddTest(t runtime.TestCase) {
-	if _, err := s.GetTestByTitle(t.Title); err != nil {
+	if _, err := s.GetTestByTitle(t.Title); err == nil {
 		panic(fmt.Sprintf("Tests %s was already added to the suite", t.Title))
 	}
 	s.TestCases = append(s.TestCases, t)

pkg/suite/suite_test.go

@@ -1 +1,48 @@
 package suite
+
+import (
+	"github.com/SimonBaeumer/commander/pkg/runtime"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test_GetNodes(t *testing.T) {
+	s := Suite{
+		Nodes: []runtime.Node{runtime.Node{}, runtime.Node{}},
+	}
+
+	assert.Len(t, s.GetNodes(), 2)
+}
+
+func Test_GetNodesByName(t *testing.T) {
+	s := Suite{
+		Nodes: []runtime.Node{runtime.Node{}, runtime.Node{Name: "node1"}},
+	}
+
+	node, e := s.GetNodeByName("node1")
+	assert.Equal(t, node.Name, "node1")
+	assert.Nil(t, e)
+
+	node, e = s.GetNodeByName("doesnt-exist")
+	assert.EqualError(t, e, "could not find node with name doesnt-exist")
+}
+
+func Test_AddTest(t *testing.T) {
+	s := Suite{TestCases: []runtime.TestCase{{Title: "exists"}}}
+	s.AddTest(runtime.TestCase{Title: "test"})
+
+	assert.Len(t, s.GetTests(), 1)
+}
+
+func Test_GetTestByTitle(t *testing.T) {
+	s := Suite{TestCases: []runtime.TestCase{{Title: "exists"}}}
+	test, err := s.GetTestByTitle("exists")
+
+	assert.Nil(t, err)
+	assert.Equal(t, "exists", test.Title)
+}
+
+func Test_GetGlobalConfig(t *testing.T) {
+	s := Suite{Config: runtime.TestConfig{Dir: "/tmp"}}
+	assert.Equal(t, "/tmp", s.GetGlobalConfig().Dir)
+}