Merge pull request #615 from KristjanESPERANTO/eslint

chore: modernize linting setup

Author: commenthol

.eslintignore

@@ -5,13 +5,13 @@ name: CI
 
 on:
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
   workflow_dispatch:
     inputs:
       ref:
-        description: 'Tag, or commit SHA to checkout (optional)'
+        description: "Tag, or commit SHA to checkout (optional)"
         required: false
 
 env:
@@ -22,15 +22,17 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ 24 ]
+        node: [24]
     name: Node ${{ matrix.node }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           ref: ${{ github.event.inputs.ref || github.ref }}
       - name: Setup Node ${{ matrix.node }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node }}
       - run: npm install --ignore-scripts
+      - run: npm run yaml
+      - run: npm run lint
       - run: npm run ci

.eslintrc.yml

@@ -0,0 +1,73 @@
+import { defineConfig, globalIgnores } from 'eslint/config'
+import js from '@eslint/js'
+import globals from 'globals'
+import { flatConfigs as importX } from 'eslint-plugin-import-x'
+import n from 'eslint-plugin-n'
+import promise from 'eslint-plugin-promise'
+import { configs as ymlConfigs } from 'eslint-plugin-yml'
+
+export default defineConfig([
+    globalIgnores([
+        'coverage/**',
+        'dist/**',
+        'lib/**',
+        'src/data.js'
+    ]),
+    {
+        files: ['**/*.js', '**/*.mjs'],
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.node,
+                ...globals.mocha
+            },
+            ecmaVersion: 'latest',
+            sourceType: 'module'
+        },
+        extends: [
+            js.configs.recommended,
+            n.configs['flat/recommended'],
+            promise.configs['flat/recommended'],
+            importX.recommended
+        ]
+    },
+    {
+        files: ['**/*.cjs'],
+        languageOptions: {
+            globals: {
+                ...globals.node,
+                ...globals.mocha
+            },
+            ecmaVersion: 'latest',
+            sourceType: 'commonjs'
+        },
+        extends: [
+            js.configs.recommended,
+            n.configs['flat/recommended'],
+            promise.configs['flat/recommended'],
+            importX.recommended
+        ],
+        rules: {
+            'n/no-unsupported-features/es-syntax': 'off'
+        }
+    },
+    {
+        // Tooling and example files follow different constraints than runtime code.
+        // Relax strict n/* checks here to avoid non-actionable lint noise.
+        files: ['eslint.config.mjs', 'examples/**', 'scripts/**'],
+        rules: {
+            'n/no-unpublished-import': 'off',
+            'n/no-missing-require': 'off',
+            'n/no-unsupported-features/es-syntax': 'off',
+            'n/no-process-exit': 'off',
+            'n/hashbang': 'off'
+        }
+    },
+    {
+        files: ['**/*.yaml', '**/*.yml'],
+        extends: [ymlConfigs['flat/standard']],
+        rules: {
+            'yml/plain-scalar': 'off'
+        }
+    }
+])

.github/workflows/ci.yml

@@ -74,7 +74,7 @@
         Object.entries(options).reduce((a, [value, label]) => {
           a.push(h(
             'option',
-            { value, selected: value == selected }, // eslint-disable-line eqeqeq
+            { value, selected: value == selected },
             label
           ))
           return a
@@ -156,7 +156,7 @@
       const filename = [g.year, n.country, n.state, n.region, g.language].filter(Boolean).join('-') + '.ics'
       download(filename, g.holidays, isFullDay)
     }
-    const handleFullday = (ev) => {
+    const handleFullday = () => {
       g.isFullDay = isFullDay = !isFullDay
     }
     return h('p',

eslint.config.mjs

@@ -208,7 +208,8 @@
     "clean:modules": "rimraf node_modules",
     "doc:attrib": "node scripts/attributions.cjs",
     "doc:tree": "node scripts/addtree.cjs",
-    "lint": "eslint --fix --ext .js,.cjs,.yaml .",
+    "lint": "eslint",
+    "lint:fix": "eslint --fix",
     "prepublishOnly": "npm run all",
     "fixtures": "mocha test/all.mocha.js --writetests --countries",
     "test": "npm-run-all test:*",
@@ -273,14 +274,15 @@
     "@babel/preset-env": "^7.29.5",
     "@commitlint/cli": "^18.6.1",
     "@commitlint/config-conventional": "^18.6.3",
+    "@eslint/js": "^10.0.1",
     "@mocha/contributors": "git+https://github.com/commenthol/contributors.git#semver:1.1.0-0",
     "babel-loader": "^9.2.1",
-    "eslint": "^8.57.1",
-    "eslint-config-standard": "^17.1.0",
-    "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-n": "^16.6.2",
-    "eslint-plugin-promise": "^6.6.0",
-    "eslint-plugin-yml": "^0.15.0",
+    "eslint": "^10.3.0",
+    "eslint-plugin-import-x": "^4.16.2",
+    "eslint-plugin-n": "^18.0.1",
+    "eslint-plugin-promise": "^7.3.0",
+    "eslint-plugin-yml": "^3.3.2",
+    "globals": "^17.6.0",
     "husky": "^9.1.7",
     "mocha": "^11.7.5",
     "npm-run-all": "^4.1.5",
@@ -296,7 +298,6 @@
     "node": ">=12.0.0"
   },
   "c4uIgnore": {
-    "eslint-plugin-yml": "^0.15.0 // newer versions do too much checking",
     "rollup": "^2.79.1 // v3 changed exports; needs refactoring first."
   },
   "packageManager": "pnpm@9.15.4+sha512.b2dc20e2fc72b3e18848459b37359a32064663e5627a51e4c74b2c29dd8e8e0491483c3abb40789cfd578bf362fb6ba8261b05f0387d76792ed6e23ea3b1b6a0"

examples/browser/test.js

@@ -1,9 +1,5 @@
 #!/usr/bin/env node
 
-/* eslint
-   key-spacing: 0
- */
-
 const fs = require('fs')
 const path = require('path')