Remove gb wls empty regions#445
Open
tekbreak wants to merge 2 commits into
Open
Conversation
| name: | ||
| en: Summer bank holiday | ||
| regions: {} | ||
| # regions: |
Contributor
There was a problem hiding this comment.
| 3. Create Json file and build the project: | ||
| ``` | ||
| npm run build | ||
| npm run yaml && npm run build |
Contributor
There was a problem hiding this comment.
Since 1ee2e82 the yaml command is already part of the build command, so we'd just add unnecessary overhead by running it twice.
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
Contributor
There was a problem hiding this comment.
@tekbreak Thanks for this PR! But I think it's not necessary anymore.
@commenthol I'd recommend closing this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for empty object in GB - WLS regions.
Fix failing build when Json file is missing