Skip to content

Remove gb wls empty regions #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tekbreak wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove gb wls empty regions #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e993b
remove empty object in GB-wls regions
tekbreak Dec 11, 2023
427fbef
fix: build fails without the Json file
tekbreak Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ If you like to add or change data please take a look at [holidays.yaml specifica

1. Fork the project
2. Create a branch for your changes
3. Build the project:
3. Create Json file and build the project:
```
npm run build
npm run yaml && npm run build

@KristjanESPERANTO KristjanESPERANTO Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 1ee2e82 the yaml command is already part of the build command, so we'd just add unnecessary overhead by running it twice.

```
4. Modify the yaml file for the country your changes apply in `./data/countries/<code>.yaml` for holiday data and/or `./data/names.yaml` for translations as appropriate
5. Generate the Json file from the yaml files with
5. Generate the new Json file from the yaml files with
```
npm run yaml
```
Expand Down
2 changes: 1 addition & 1 deletion data/countries/GB.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ holidays:
1st monday before 09-01:
name:
en: Summer bank holiday
regions: {}
# regions:

@KristjanESPERANTO KristjanESPERANTO Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done via PR 626: https://github.com/commenthol/date-holidays/pull/626/changes#diff-a0f7cc3b049138a7e2523d7c2fba70a00cbd92908913d5aabeaaf4d4708c14dfR554

# AGY:
# name: Anglesey
# BGE:
Expand Down