Skip to content

fix(BE): use Belgian holiday names and update sources#617

Merged
commenthol merged 1 commit into
commenthol:masterfrom
KristjanESPERANTO:be
May 20, 2026
Merged

fix(BE): use Belgian holiday names and update sources#617
commenthol merged 1 commit into
commenthol:masterfrom
KristjanESPERANTO:be

Conversation

@KristjanESPERANTO
Copy link
Copy Markdown
Contributor

Belgian Dutch uses different terms than generic Dutch, like Paasmaandag instead of Tweede paasdag.

Comment thread data/countries/BE.yaml Outdated
@@ -1,5 +1,7 @@
holidays:
# @attrib https://de.m.wikipedia.org/wiki/Feiertage_in_Belgien
# @attrib https://www.emploi.belgique.be/fr/themes/international/detachement/conditions-de-travail-respecter-en-cas-de-detachement-en-2
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that the reference is in the public domain, please change to @source instead of @attrib.

@attrib is used for attribution to comply with CC BY-SA 3.0 as as Wikipedia demands.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I hadn't even thought about that. But it makes sense. I just corrected it 🙂

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks. Will publish the next minor version :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There will be more PRs like this, but not today.

Belgian Dutch uses different terms than generic Dutch,
like Paasmaandag instead of Tweede paasdag.
Sources updated to official government pages.
@commenthol commenthol merged commit 18ec921 into commenthol:master May 20, 2026
1 check passed
@KristjanESPERANTO KristjanESPERANTO deleted the be branch May 20, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants