Skip to content

Commit bb667b4

Browse files
authored
Merge pull request #1042 from ZanochkynYehor/SUPPORT-38780-parcelmixin-todraftbuilder-npe
2 parents 66a3807 + 758365c commit bb667b4

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

commercetools/commercetools-sdk-java-api/src/main/java/com/commercetools/api/models/order/ParcelMixin.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
package com.commercetools.api.models.order;
33

44
import java.util.List;
5+
import java.util.Optional;
56

67
import com.commercetools.api.models.type.CustomFields;
78

@@ -19,7 +20,7 @@ public default ParcelDraftBuilder toDraftBuilder() {
1920
.measurements(this.getMeasurements())
2021
.trackingData(this.getTrackingData())
2122
.items(this.getItems())
22-
.custom(this.getCustom().toDraft());
23+
.custom(Optional.ofNullable(this.getCustom()).map(CustomFields::toDraft).orElse(null));
2324
}
2425

2526
public default ParcelDraft toDraft() {

commercetools/internal-docs/src/test/java/example/HelperMethodsTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,10 +957,17 @@ public void parcelToDraft() {
957957
final ParcelDraft parcelDraft = parcel.toDraft();
958958
}
959959

960+
@Test
960961
public void parcelToDraftBuilder() {
961-
final Parcel parcel = ParcelBuilder.of().id("parcel-id").build();
962+
final Parcel parcel = ParcelBuilder.of()
963+
.id("parcel-id")
964+
.createdAt(ZonedDateTime.now())
965+
.build();
962966

963967
final ParcelDraftBuilder parcelDraftBuilder = parcel.toDraftBuilder();
968+
969+
Assertions.assertNotNull(parcelDraftBuilder);
970+
Assertions.assertNull(parcelDraftBuilder.getCustom());
964971
}
965972

966973
public void deliveryToDraft() {

0 commit comments

Comments
 (0)