fix(ts-client): fix issue with undefined body (#1199)

- fix issue with undefined json body for HEAD requests

Author: ajimae

.changeset/modern-feet-camp.md

@@ -0,0 +1,5 @@
+---
+'@commercetools/ts-client': patch
+---
+
+Fix issue with undefined response body

.nvmrc

@@ -1 +1 @@
-22.19.0
+24.11.0

packages/checkout-sdk/test/helpers/api-helpers.ts

@@ -28,6 +28,7 @@ const ctpClient = new ClientBuilder()
   .withHttpMiddleware(httpMiddleware)
   .build()
 
+export type { Transaction } from '../../src'
 export const ctpApiBuilder = createApiBuilderFromCtpClient(
   ctpClient,
   'https://checkout.europe-west1.gcp.commercetools.com'

packages/checkout-sdk/test/integration-tests/transaction.test.ts

@@ -1,8 +1,8 @@
 import { ctpApiBuilder as ctpApiRoot } from '../helpers/ctp-api-helper'
-import { ctpApiBuilder } from '../helpers/api-helpers'
+import { ctpApiBuilder, Transaction } from '../helpers/api-helpers'
 
 describe('::transaction', () => {
-  let cart: any
+  let cart: any, transactions: Transaction
 
   afterAll(async () => {
     const updatedCart = await ctpApiRoot
@@ -31,7 +31,7 @@ describe('::transaction', () => {
   })
 
   it('should create a transaction using created cart', async () => {
-    const transactions = await ctpApiBuilder
+    const _transactions = await ctpApiBuilder
       .transactions()
       .post({
         body: {
@@ -59,7 +59,19 @@ describe('::transaction', () => {
       })
       .execute()
 
-    expect(transactions).toBeDefined()
-    expect(transactions.statusCode).toEqual(201)
+    expect(_transactions).toBeDefined()
+    expect(_transactions.statusCode).toEqual(201)
+    transactions = _transactions.body
+  })
+
+  it('should retrieve a transaction using ID', async () => {
+    const _transaction = await ctpApiBuilder
+      .transactions()
+      .withId({ id: transactions.id })
+      .get()
+      .execute()
+
+    expect(_transaction).toBeDefined()
+    expect(_transaction.statusCode).toEqual(200)
   })
 })

packages/sdk-client-v3/src/utils/executor.ts

@@ -146,12 +146,22 @@ export default async function executor(request: HttpClientConfig) {
       }
 
       const response: IResponse = await executeWithRetry()
+
+      // check if it's a HEAD request, then return
+      if (rest.method == 'HEAD') {
+        return {
+          data: null,
+          retryCount,
+          statusCode: response.status || response.statusCode || data.statusCode,
+          headers: response.headers,
+        }
+      }
+
       try {
         // try to parse the `fetch` response as text
         if (response.text && typeof response.text == 'function') {
-          result =
-            (await response.text()) ||
-            JSON.stringify(response[Object.getOwnPropertySymbols(response)[1]])
+          result = await response.text()
+
           data = JSON.parse(result)
         } else {
           // axios response