Skip to content

[Chore] Avoid Manually Setting Request Content Length#1266

Merged
ajimae merged 2 commits into
masterfrom
chore/avoid-manually-setting-request-content-length
May 12, 2026
Merged

[Chore] Avoid Manually Setting Request Content Length#1266
ajimae merged 2 commits into
masterfrom
chore/avoid-manually-setting-request-content-length

Conversation

@ajimae
Copy link
Copy Markdown
Member

@ajimae ajimae commented May 7, 2026

Summary

Avoid setting content-length manually

Completed Tasks

  • remove manually calculated content-length in the SDK and allow underlying client to carryout the computation

Related Issue

#1262

ajimae added 2 commits May 7, 2026 17:30
- remove user-specified request content-lenght header
- add release changeset
@ajimae ajimae requested a review from a team as a code owner May 7, 2026 15:37
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: c4d1cde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/ts-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ajimae ajimae changed the title [Chore] Aavoid Manually Setting Request Content Length [Chore] Avoid Manually Setting Request Content Length May 7, 2026
@ajimae ajimae requested review from jenschude and johnsonogwuru May 7, 2026 15:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.62%. Comparing base (6d813e2) to head (c4d1cde).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
- Coverage   97.62%   97.62%   -0.01%     
==========================================
  Files          88       88              
  Lines        1347     1345       -2     
  Branches      351      346       -5     
==========================================
- Hits         1315     1313       -2     
- Misses         26       28       +2     
+ Partials        6        4       -2     
Flag Coverage Δ
test-coverage 97.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ajimae ajimae merged commit 6814099 into master May 12, 2026
13 checks passed
@ajimae ajimae deleted the chore/avoid-manually-setting-request-content-length branch May 12, 2026 12:30
@ct-changesets ct-changesets Bot mentioned this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants