Skip to content

[Chore] Remove UUID npm package#1274

Merged
ajimae merged 3 commits into
masterfrom
chore/remove-the-uuid-package
May 12, 2026
Merged

[Chore] Remove UUID npm package#1274
ajimae merged 3 commits into
masterfrom
chore/remove-the-uuid-package

Conversation

@ajimae
Copy link
Copy Markdown
Member

@ajimae ajimae commented May 11, 2026

Summary

Remove UUID npm package entirely

Completed Tasks

  • remove the uuid package
  • add a helper to generate a uuid-like string

Related Issue

#1273

- remove the uuid package
- add a helper to generate a uuid-like string
@ajimae ajimae requested a review from jenschude May 11, 2026 13:34
@ajimae ajimae requested a review from a team as a code owner May 11, 2026 13:34
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 4a1c4ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/ts-sdk-apm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- add release changeset for package release
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.62%. Comparing base (6814099) to head (4a1c4ec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          88       88           
  Lines        1345     1345           
  Branches      350      350           
=======================================
  Hits         1313     1313           
  Misses         26       26           
  Partials        6        6           
Flag Coverage Δ
test-coverage 97.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"@opentelemetry/sdk-node": "^0.205.0",
"dd-trace": "^5.31.0",
"newrelic": "^13.0.0",
"uuid": "13.0.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just bumping the version?

also, in our lib, the UUID that is referenced in ts-sdk-apm is 11.1.0 and we are using @commercetools/ts-sdk-apm v4.4.1

maybe the issue just that you don't have the latest code in the release package?

Copy link
Copy Markdown
Member Author

@ajimae ajimae May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now completely dropping all reference to the UUID package. In the main SDK we did away with the package as well.

Does your application mandatorily need to have this UUID package?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's fine, we can include it manually if we need it, was just checking why would you rewrite a logic. Thx

@ajimae ajimae merged commit 55b82c5 into master May 12, 2026
18 of 20 checks passed
@ajimae ajimae deleted the chore/remove-the-uuid-package branch May 12, 2026 13:08
@ct-changesets ct-changesets Bot mentioned this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants