[Chore] Remove UUID npm package#1274
Conversation
- remove the uuid package - add a helper to generate a uuid-like string
🦋 Changeset detectedLatest commit: 4a1c4ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- add release changeset for package release
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 88 88
Lines 1345 1345
Branches 350 350
=======================================
Hits 1313 1313
Misses 26 26
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "@opentelemetry/sdk-node": "^0.205.0", | ||
| "dd-trace": "^5.31.0", | ||
| "newrelic": "^13.0.0", | ||
| "uuid": "13.0.0" |
There was a problem hiding this comment.
why not just bumping the version?
also, in our lib, the UUID that is referenced in ts-sdk-apm is 11.1.0 and we are using @commercetools/ts-sdk-apm v4.4.1
maybe the issue just that you don't have the latest code in the release package?
There was a problem hiding this comment.
We are now completely dropping all reference to the UUID package. In the main SDK we did away with the package as well.
Does your application mandatorily need to have this UUID package?
There was a problem hiding this comment.
no it's fine, we can include it manually if we need it, was just checking why would you rewrite a logic. Thx
Summary
Remove
UUIDnpm package entirelyCompleted Tasks
Related Issue
#1273