Skip to content

Commit 0166991

Browse files
authored
Make mkdocsBuild part of the checks on CI build. (#790)
* remove relative links to pass mkdocsBuild. * add ./gradlew mkdocsBuild to checks.
1 parent 34e33b7 commit 0166991

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ jobs:
1717
run: ./gradlew pmdBenchmark pmdIntegrationTest pmdMain pmdTest
1818
- name: Spotbugs
1919
run: ./gradlew spotbugsBenchmark spotbugsIntegrationTest spotbugsMain spotbugsTest
20+
- name: mkdocsBuild
21+
run: ./gradlew mkdocsBuild
2022

2123
tests:
2224
name: Tests

docs/RELEASE_NOTES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
[Jar](https://search.maven.org/artifact/com.commercetools/commercetools-sync-java/8.0.0/jar)
3333

3434
- 🚧 **Breaking Changes** (1)
35-
- Removed support of changing the attribute definition type [#787](https://github.com/commercetools/commercetools-sync-java/pull/787) since removal and addition of the attribute with the same name in a single request is not possible by commercetools API anymore. For more information please [check](../docs/adr/0003-syncing-attribute-type-changes.md).
35+
- Removed support of changing the attribute definition type [#787](https://github.com/commercetools/commercetools-sync-java/pull/787) since removal and addition of the attribute with the same name in a single request is not possible by commercetools API anymore. For more information please [check](https://github.com/commercetools/commercetools-sync-java/blob/master/docs/adr/0003-syncing-attribute-type-changes.md).
3636

3737
-**Enhancement** (1)
3838
- Use the new concurrency keyword on github actions to limit the concurrency of the workflow runs. [#772](https://github.com/commercetools/commercetools-sync-java/issues/772)

docs/usage/PRODUCT_TYPE_SYNC.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,4 +278,4 @@ More examples of those utils for different fields can be found [here](https://gi
278278

279279
## Caveats
280280
1. The order of attribute definitions in the synced product types is not guaranteed.
281-
2. Changing the attribute definition type is not supported. Instead, remove and re-add it with a new type manually, either over API or merchant center. For more information please [check](../../docs/adr/0003-syncing-attribute-type-changes.md).
281+
2. Changing the attribute definition type is not supported. Instead, remove and re-add it with a new type manually, either over API or merchant center. For more information please [check](https://github.com/commercetools/commercetools-sync-java/blob/master/docs/adr/0003-syncing-attribute-type-changes.md).

0 commit comments

Comments
 (0)