Merge pull request #187 from commercetools/161-gradle-task-exec-order

#161: Explicitly define execution order of gradle tasks.

Author: heshamMassoud

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,6 +14,7 @@
     - [ ] Unit 
     - [ ] Integration
 - [ ] Documentation
+- [ ] Add Release Notes entry.
 <!-- Two persons should review a PR, don't forget to assign them. -->
 
 #### Hints for Review

build.gradle

@@ -29,4 +29,5 @@ apply from: "$rootDir/gradle-scripts/findbugs.gradle"
 apply from: "$rootDir/gradle-scripts/maven-publish.gradle"
 apply from: "$rootDir/gradle-scripts/bintray-publish.gradle"
 apply from: "$rootDir/gradle-scripts/oss-publish.gradle"
-apply from: "$rootDir/gradle-scripts/javadocs-publish.gradle"
+apply from: "$rootDir/gradle-scripts/javadocs-publish.gradle"
+apply from: "$rootDir/gradle-scripts/execution-order.gradle"

docs/RELEASE_NOTES.md

@@ -40,19 +40,23 @@
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 <!--
-### v1.0.0-M5 -  Nov 7, 2017
+### v1.0.0-M5 -  Nov 16, 2017
 [Commits](https://github.com/commercetools/commercetools-sync-java/compare/v1.0.0-M4...v1.0.0-M5) |
 [Javadoc](https://commercetools.github.io/commercetools-sync-java/v/v1.0.0-M5/) | 
 [Jar](https://bintray.com/commercetools/maven/commercetools-sync-java/v1.0.0-M5)
 
-**New Features** (1)
+**New Features** (3)
 - **Inventory Sync** - Introduced `beforeUpdateCallback` which is applied after generation of update actions and before 
 actual InventoryEntry update. [#169](https://github.com/commercetools/commercetools-sync-java/issues/169)
+- **Build Tools** - Added `Add Release Notes entry` checkbox in PR template on Github repo. [#161](https://github.com/commercetools/commercetools-sync-java/issues/161)
+- **Commons** - Appended library name and version to User-Agent headers of JVM SDK clients using the library. [#142](https://github.com/commercetools/commercetools-sync-java/issues/142)
 
-**Enhancements** (1)
+**Enhancements** (3)
 - **Commons** - `setUpdateActionsCallback` has been renamed to `beforeUpdateCallback` and now takes a TriFunction instead 
 of Function, which adds more information about the generated list of update actions, namely, the old resource being 
 updated and the new resource draft. [#169](https://github.com/commercetools/commercetools-sync-java/issues/169)
+- **Build Tools** - Explicitly specified gradle tasks execution order in execution-order.gradle. [#161](https://github.com/commercetools/commercetools-sync-java/issues/161)
+- **Build Tools** - Set PMD to run before Integration tests. [#161](https://github.com/commercetools/commercetools-sync-java/issues/161)
 
 **Build Tools** (1)
 - **Commons** - Appended library name and version to User-Agent headers of JVM SDK clients using the library. [#142](https://github.com/commercetools/commercetools-sync-java/issues/142)
@@ -71,6 +75,7 @@ updated and the new resource draft. [#169](https://github.com/commercetools/comm
 to `removeOtherSetEntries`, `removeOtherCollectionEntries` and `removeOtherProperties`. [#169](https://github.com/commercetools/commercetools-sync-java/issues/169)
 - **Product Sync** - Renamed `setSyncFilter` to `syncFilter`. [#169](https://github.com/commercetools/commercetools-sync-java/issues/169)
 -->
+
 ### v1.0.0-M4 -  Nov 7, 2017
 [Commits](https://github.com/commercetools/commercetools-sync-java/compare/v1.0.0-M3...v1.0.0-M4) |
 [Javadoc](https://commercetools.github.io/commercetools-sync-java/v/v1.0.0-M4/) | 

gradle-scripts/execution-order.gradle

@@ -0,0 +1,47 @@
+/**
+ * Contains declarations of tasks' execution orders.
+ */
+
+/**
+ * Sub-tasks execution order
+ */
+//Compile sub-tasks execution order
+compileTestJava.mustRunAfter compileJava
+compileIntegrationTestJava.mustRunAfter compileTestJava
+
+//Checkstyle sub-tasks execution order
+checkstyleTest.mustRunAfter checkstyleMain
+checkstyleIntegrationTest.mustRunAfter checkstyleTest
+
+//PMD sub-tasks execution order
+pmdTest.mustRunAfter pmdMain
+pmdIntegrationTest.mustRunAfter pmdTest
+
+//FindBugs sub-tasks execution order
+findbugsTest.mustRunAfter findbugsMain
+findbugsIntegrationTest.mustRunAfter findbugsTest
+
+//Jacoco sub-tasks execution order
+jacocoTestReport.mustRunAfter jacocoTestCoverageVerification
+
+/**
+ * Global execution order
+ */
+
+// Ensure CheckStyle runs after Compile
+checkstyleMain.mustRunAfter compileIntegrationTestJava
+// Ensure PMD runs after Checkstyle
+pmdMain.mustRunAfter checkstyleIntegrationTest
+// Ensure FindBugs runs after PMD
+findbugsMain.mustRunAfter pmdIntegrationTest
+// Ensure unit tests are run after FindBugs
+test.mustRunAfter findbugsIntegrationTest
+// Ensure integration tests are run after unit tests and are part of check
+check.dependsOn integrationTest
+integrationTest.mustRunAfter test
+// Ensure jacocoTestCoverageVerification and jacocoTestReport are part of check
+check.dependsOn jacocoTestCoverageVerification
+check.dependsOn jacocoTestReport
+// Ensure jacocoTestCoverageVerification and jacocoTestReport run after integrationTest
+jacocoTestCoverageVerification.mustRunAfter integrationTest
+jacocoTestReport.mustRunAfter integrationTest

gradle-scripts/findbugs.gradle

@@ -11,6 +11,3 @@ tasks.withType(FindBugs) {
     }
 }
 
-findbugsTest.mustRunAfter findbugsMain
-findbugsIntegrationTest.mustRunAfter findbugsTest
-

gradle-scripts/integration-tests.gradle

@@ -19,5 +19,3 @@ task integrationTest(type: Test) {
     outputs.upToDateWhen { false }
 }
 
-check.dependsOn integrationTest
-integrationTest.mustRunAfter test

gradle-scripts/jacoco.gradle

@@ -28,7 +28,4 @@ jacocoTestReport {
         html.enabled = false
         csv.enabled = false
     }
-}
-
-check.dependsOn jacocoTestCoverageVerification
-test.finalizedBy jacocoTestReport
+}

gradle-scripts/pmd.gradle

@@ -15,6 +15,3 @@ tasks.withType(Pmd) {
         xml.enabled = false
     }
 }
-
-pmdTest.mustRunAfter pmdMain
-pmdIntegrationTest.mustRunAfter pmdTest