Use otel4s semantic conventions to verify metrics definition#272
Open
iRevive wants to merge 1 commit intocommercetools:mainfrom
Open
Use otel4s semantic conventions to verify metrics definition#272iRevive wants to merge 1 commit intocommercetools:mainfrom
iRevive wants to merge 1 commit intocommercetools:mainfrom
Conversation
iRevive
commented
Nov 17, 2025
| assertEquals(md.unit, Some(spec.unit), clue) | ||
|
|
||
| val required = spec.attributeSpecs | ||
| .filter(_.requirement.level == Requirement.Level.Required) |
Author
There was a problem hiding this comment.
You can also filter attributes by stability:
.filter(_.stability == Stability.stable)
iRevive
commented
Nov 17, 2025
| operationDuration.recordDuration(TimeUnit.SECONDS, buildAttributes(Attributes(InternalMessagingAttributes.Send), _)) | ||
| operationDuration.recordDuration( | ||
| TimeUnit.SECONDS, | ||
| buildAttributes(Attributes(InternalMessagingAttributes.Send, InternalMessagingAttributes.SendOp), _)) |
iRevive
changed the title
Collaborator
|
Thanks a lot, I am still discovering the power of the semconv module you added :-) I will look into this and improve our integration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks, thanks for using otel4s!
The PR shows additional capabilities of otel4s and is not meant to be merged. You could adopt some ideas that could be helpful for your project.
MessagingExperimentalMetricsare generated from the specification, which includes the instrument name, description, unit, required attributes, and other details.You can also use a generated spec to verify that exported metrics have all required attributes.