Merge pull request #1626 from commercetools/enableDiscounted-option

feat(sync-actions): add enableDiscounted option to product

Author: markus-azer

packages/sync-actions/src/product-actions.js

@@ -236,7 +236,8 @@ function _buildVariantImagesAction(
 function _buildVariantPricesAction(
   diffedPrices,
   oldVariant = {},
-  newVariant = {}
+  newVariant = {},
+  enableDiscounted = false
 ) {
   const addPriceActions = []
   const changePriceActions = []
@@ -260,7 +261,7 @@ function _buildVariantPricesAction(
         // Remove read-only fields
         const patchedPrice = price.map((p) => {
           const shallowClone = { ...p }
-          delete shallowClone.discounted
+          if (enableDiscounted !== true) delete shallowClone.discounted
           return shallowClone
         })
 
@@ -273,11 +274,11 @@ function _buildVariantPricesAction(
         // Remove the discounted field and make sure that the price
         // still has other values, otherwise simply return
         const filteredPrice = { ...price }
-        delete filteredPrice.discounted
+        if (enableDiscounted !== true) delete filteredPrice.discounted
         if (Object.keys(filteredPrice).length) {
           // At this point price should have changed, simply pick the new one
           const newPrice = { ...newObj }
-          delete newPrice.discounted
+          if (enableDiscounted !== true) delete newPrice.discounted
 
           changePriceActions.push({
             action: 'changePrice',
@@ -607,7 +608,13 @@ export function actionsMapImages(diff, oldObj, newObj, variantHashMap) {
   return actions
 }
 
-export function actionsMapPrices(diff, oldObj, newObj, variantHashMap) {
+export function actionsMapPrices(
+  diff,
+  oldObj,
+  newObj,
+  variantHashMap,
+  enableDiscounted
+) {
   let addPriceActions = []
   let changePriceActions = []
   let removePriceActions = []
@@ -626,7 +633,8 @@ export function actionsMapPrices(diff, oldObj, newObj, variantHashMap) {
         const [a, c, r] = _buildVariantPricesAction(
           variant.prices,
           oldVariant,
-          newVariant
+          newVariant,
+          enableDiscounted
         )
 
         addPriceActions = addPriceActions.concat(a)

packages/sync-actions/src/products.js

@@ -42,7 +42,7 @@ function createProductMapActions(
     options: Object = {}
   ): Array<UpdateAction> {
     const allActions = []
-    const { sameForAllAttributeNames } = options
+    const { sameForAllAttributeNames, enableDiscounted } = options
     const { publish } = newObj
 
     const variantHashMap = findMatchingPairs(
@@ -108,7 +108,13 @@ function createProductMapActions(
 
     allActions.push(
       mapActionGroup('prices', (): Array<UpdateAction> =>
-        productActions.actionsMapPrices(diff, oldObj, newObj, variantHashMap)
+        productActions.actionsMapPrices(
+          diff,
+          oldObj,
+          newObj,
+          variantHashMap,
+          enableDiscounted
+        )
       )
     )
 

packages/sync-actions/test/product-sync-prices.spec.js

@@ -147,6 +147,61 @@ describe('Actions', () => {
       ])
     })
 
+    test('should build actions for prices with discounted when enableDiscounted is set to true', () => {
+      const actions = productsSync.buildActions(now, before, {
+        enableDiscounted: true,
+      })
+      expect(actions).toEqual([
+        {
+          action: 'changePrice',
+          priceId: '111',
+          price: {
+            country: 'US',
+            id: '111',
+            value: { currencyCode: 'EUR', centAmount: 2000 },
+            discounted: {
+              value: { centAmount: 4000, currencyCode: 'EUR' },
+              discount: { typeId: 'product-discount', id: 'pd1' },
+            },
+          },
+        },
+        {
+          action: 'changePrice',
+          price: {
+            channel: {
+              id: 'ch1',
+              typeId: 'channel',
+            },
+            country: 'DE',
+            customerGroup: {
+              id: 'cg1',
+              typeId: 'customer-group',
+            },
+            id: '444',
+            value: {
+              centAmount: 1000,
+              currencyCode: 'EUR',
+              fractionDigits: undefined,
+              type: undefined,
+            },
+          },
+          priceId: '444',
+        },
+        { action: 'removePrice', priceId: '222' },
+        {
+          action: 'addPrice',
+          variantId: 3,
+          price: {
+            value: { currencyCode: 'USD', centAmount: 5000 },
+            country: 'US',
+            customerGroup: { typeId: 'customer-group', id: 'cg1' },
+            channel: { typeId: 'channel', id: 'ch1' },
+            validFrom,
+          },
+        },
+      ])
+    })
+
     test('should not delete the discounted field from the original object', () => {
       expect('discounted' in before.masterVariant.prices[0]).toBeTruthy()
       expect('discounted' in now.masterVariant.prices[0]).toBeTruthy()