BMU-401 fix(sync-actions): fix type sync-actions errors (#1852)

* fix(sync-actions): fix type sync-actions errors

* test(sync-actions): update test description

* ci(sync-actions): add changeset

Author: markus-azer

.changeset/rich-taxis-shake.md

@@ -0,0 +1,6 @@
+---
+'@commercetools/sync-actions': minor
+---
+
+types sync-actions: fix action structure for changeFieldDefinitionOrder
+fix internal type sync error by adding optional chaining

packages/sync-actions/src/types-actions.js

@@ -136,7 +136,7 @@ export function actionsMapFieldDefinitions(
           label: extractedPairs.newObj.label,
           fieldName: extractedPairs.oldObj.name,
         })
-      } else if (diffValue.type.values) {
+      } else if (diffValue?.type?.values) {
         actions.push(
           ...actionsMapEnums(
             extractedPairs.oldObj.name,
@@ -152,7 +152,7 @@ export function actionsMapFieldDefinitions(
         if (diffValue.length === 3 && diffValue[2] === 3) {
           actions.push({
             action: 'changeFieldDefinitionOrder',
-            fieldNames: next,
+            fieldNames: next.map((n) => n.name),
           })
         } else {
           const deltaValue = diffPatcher.getDeltaValue(diffValue)

packages/sync-actions/test/types-sync-fields.spec.js

@@ -110,7 +110,7 @@ describe('Actions', () => {
       expect(updateActions).toEqual([
         {
           action: 'changeFieldDefinitionOrder',
-          fieldNames: [{ name: 'second' }, { name: 'first' }],
+          fieldNames: ['second', 'first'],
         },
       ])
     })
@@ -336,4 +336,35 @@ describe('Actions', () => {
       ])
     })
   })
+
+  /**
+   * there is no update action for fieldDefinition -> required,
+   * so this field is immutable and unchangeable.
+   * in case of changing it, this were throwing `Cannot read properties of undefined` cause its nested field.
+   * below test is making sure this field is ignored and without any internal package errors.
+   */
+  describe('should ignore changes in required field in fieldDefinition', () => {
+    beforeEach(() => {
+      before = createTestType({
+        fieldDefinitions: [
+          {
+            name: 'first',
+            required: true,
+          },
+        ],
+      })
+      now = createTestType({
+        fieldDefinitions: [
+          {
+            name: 'first',
+            required: false,
+          },
+        ],
+      })
+      updateActions = typesSync.buildActions(now, before)
+    })
+    test('should return no action', () => {
+      expect(updateActions).toEqual([])
+    })
+  })
 })