Skip to content

PDM-236 Add support for product level attributes#1969

Merged
markus-azer merged 16 commits into
masterfrom
pdm-236
Jun 20, 2025
Merged

PDM-236 Add support for product level attributes#1969
markus-azer merged 16 commits into
masterfrom
pdm-236

Conversation

@peter-gerhard
Copy link
Copy Markdown
Contributor

@peter-gerhard peter-gerhard commented Jun 16, 2025

https://commercetools.atlassian.net/browse/PDM-236

Add Support for importing products, product drafts with product level attributes

  • Add Action Generation for Product Level Attributes on Products
    • Refactor while keeping tests green
    • Add logic for product level attribute actions
    • Add tests for product level attribute actions and get them green
  • Add Action Generation for Product Level Attributes on Product-Types
    • The only action affected is addAttributeDefinition which takes a definition. By adding the level to the raml (other repo) it will automatically work to import product types with product level attributes

I suggest t review commit by commit to get a more meaningful diff

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: 9d826de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/sync-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@peter-gerhard peter-gerhard changed the title PDM-236 PDM-236 Add support for product level attributes Jun 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.47%. Comparing base (e91cb18) to head (9d826de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/sync-actions/src/product-actions.js 89.39% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
- Coverage   98.58%   98.47%   -0.12%     
==========================================
  Files         117      117              
  Lines        2968     3013      +45     
  Branches      834      854      +20     
==========================================
+ Hits         2926     2967      +41     
- Misses         40       42       +2     
- Partials        2        4       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peter-gerhard peter-gerhard marked this pull request as ready for review June 18, 2025 12:30
Comment thread packages/sync-actions/src/products.js
@markus-azer markus-azer self-requested a review June 20, 2025 09:53
@markus-azer markus-azer merged commit 961de7c into master Jun 20, 2025
13 of 15 checks passed
@markus-azer markus-azer deleted the pdm-236 branch June 20, 2025 10:19
@ct-changesets ct-changesets Bot mentioned this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants