Skip to content

fix(products): handle product level attributes when value is undefined #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasnieto92 merged 5 commits into from
Sep 19, 2025
Merged

fix(products): handle product level attributes when value is undefined #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1fb0460
fix(products): handle product level attributes when type is not passed
nicolasnieto92 Sep 19, 2025
35464f2
chore(products): add changeset for handle product level attributes wh…
nicolasnieto92 Sep 19, 2025
e3ea967
fix(products): fix undefined value being passed in product level attr…
nicolasnieto92 Sep 19, 2025
0b8ac89
chore(products): fix changeset
nicolasnieto92 Sep 19, 2025
9a4c036
chore(products): add comments
nicolasnieto92 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-crews-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@commercetools/sync-actions': minor
---

handle product level attributes when money value is undefined
7 changes: 4 additions & 3 deletions packages/sync-actions/src/product-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ function _buildAttributeValue(
newAttributeValue
) {
let value

if (Array.isArray(diffedValue))
value = diffpatcher.getDeltaValue(diffedValue, oldAttributeValue)
else if (typeof diffedValue === 'string')
Expand Down Expand Up @@ -175,7 +174,8 @@ function _buildSetAttributeAction(
attribute,
sameForAllAttributeNames
) {
if (!attribute) return undefined
// in the case of diffedValue being null or undefined, _buildAttributeValue will fail.
if (!attribute || !diffedValue) return undefined
Copy link
Copy Markdown
Member

@markus-azer markus-azer Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this package already super confusing, please feel free to add some comment or ask AI to add it :)

Copy link
Copy Markdown
Contributor Author

@nicolasnieto92 nicolasnieto92 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here 😄 -> 9a4c036


let action = {
action: 'setAttribute',
Expand Down Expand Up @@ -219,7 +219,8 @@ function _buildSetProductAttributeAction(
oldProductData,
newAttribute
) {
if (!newAttribute) return undefined
// in the case of diffedValue being null or undefined, _buildAttributeValue will fail.
if (!newAttribute || !diffedValue) return undefined

const action = {
action: 'setProductAttribute',
Expand Down
31 changes: 31 additions & 0 deletions packages/sync-actions/test/product-sync-base.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,4 +837,35 @@ describe('Actions', () => {
{ action: 'setProductAttribute', name: 'indexedAttr', value: 'newValue' },
])
})

test('should not fail when type is not passed', () => {
const before = {
attributes: [
{
name: 'price',
value: { centAmount: 100, currencyCode: 'USD' },
},
],
}

const now = {
attributes: [
{
name: 'price',
value: undefined,
},
],
}
const actions = productsSync.buildActions(now, before)

const expected = [
{
action: 'setProductAttribute',
name: 'price',
value: now.attributes[0].value,
},
]

expect(actions).toEqual(expected)
})
})