Skip to content

Commit 7ff05e9

Browse files
mo-alrasclaude
andcommitted
Add test cases for shorthand and description-form parameters
Ensure the rule handles all RAML parameter definition forms: shorthand, typed, and with descriptions (inline types). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3c9312f commit 7ff05e9

2 files changed

Lines changed: 26 additions & 1 deletion

File tree

ctp-validators/src/test/groovy/com/commercetools/rmf/validators/ValidatorRulesTest.groovy

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,10 @@ class ValidatorRulesTest extends Specification implements ValidatorFixtures {
481481
def uri = uriFromClasspath("/with-total-default-rule.raml")
482482
def result = new RamlModelBuilder(validators).buildApi(uri)
483483
then:
484-
result.validationResults.size() == 2
484+
result.validationResults.size() == 4
485485
result.validationResults[0].message == "Query parameter \"withTotal\" of method \"GET /invalid-resource-true\" must have a default value of \"false\", found \"true\""
486486
result.validationResults[1].message == "Query parameter \"withTotal\" of method \"GET /invalid-resource-no-default\" must have a default value of \"false\""
487+
result.validationResults[2].message == "Query parameter \"withTotal\" of method \"GET /invalid-resource-shorthand\" must have a default value of \"false\""
488+
result.validationResults[3].message == "Query parameter \"withTotal\" of method \"GET /invalid-resource-desc-true\" must have a default value of \"false\", found \"true\""
487489
}
488490
}

ctp-validators/src/test/resources/with-total-default-rule.raml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,29 @@ title: with total default rule
2424
type: boolean
2525
required: false
2626

27+
/invalid-resource-shorthand:
28+
get:
29+
queryParameters:
30+
withTotal: boolean
31+
32+
/invalid-resource-desc-true:
33+
get:
34+
queryParameters:
35+
withTotal:
36+
description: Include total count in response
37+
type: boolean
38+
default: true
39+
required: false
40+
41+
/valid-resource-desc:
42+
get:
43+
queryParameters:
44+
withTotal:
45+
description: Include total count in response
46+
type: boolean
47+
default: false
48+
required: false
49+
2750
/unrelated-resource:
2851
get:
2952
queryParameters:

0 commit comments

Comments
 (0)