Skip to content

4.8.3 candidate#1457

Merged
Lee-W merged 80 commits into
masterfrom
refactors
Jun 9, 2025
Merged

4.8.3 candidate#1457
Lee-W merged 80 commits into
masterfrom
refactors

Conversation

@Lee-W

@Lee-W Lee-W commented May 25, 2025

Copy link
Copy Markdown
Member

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Lee-W

Lee-W commented May 25, 2025

Copy link
Copy Markdown
Member Author

Hey @woile @noirbizarre , I'd like to merge this one in the next few days. It contains all the PRs I reviewed this days to avoid bumping version too quickly

@Lee-W Lee-W changed the title Refactors 4.8.3 candidate May 25, 2025
@codecov

codecov Bot commented May 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (120d514) to head (79404a4).
Report is 742 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   97.33%   97.96%   +0.62%     
==========================================
  Files          42       58      +16     
  Lines        2104     2703     +599     
==========================================
+ Hits         2048     2648     +600     
+ Misses         56       55       -1     
Flag Coverage Δ
unittests 97.96% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W

Lee-W commented May 25, 2025

Copy link
Copy Markdown
Member Author

@bearomorphism, please let us know if you want us to include anything in the next release. We'll try to review them

@bearomorphism

Copy link
Copy Markdown
Collaborator

#1449

@bearomorphism

Copy link
Copy Markdown
Collaborator

and probably #1453 which I'm fixing

@bearomorphism

Copy link
Copy Markdown
Collaborator

and #1442
I'm resolving the conflict

@bearomorphism

Copy link
Copy Markdown
Collaborator

#1428

@bearomorphism

Copy link
Copy Markdown
Collaborator

Those are small PRs (<60 lines of code changes excluding tests). Thanks 🙇

@bearomorphism

Copy link
Copy Markdown
Collaborator

And probably #1466

@Lee-W

Lee-W commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

I hope to get it done this week... will try to review some more 💪

@Lee-W Lee-W marked this pull request as ready for review June 8, 2025 08:14
@Lee-W Lee-W requested review from noirbizarre and woile as code owners June 8, 2025 08:14
@bearomorphism

Copy link
Copy Markdown
Collaborator

@Lee-W pls try merging #1509 to fix CI

@bearomorphism

bearomorphism commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

@bearomorphism bearomorphism mentioned this pull request Jun 8, 2025
1 task
@bearomorphism

Copy link
Copy Markdown
Collaborator

This commit is good
5a83aeb

@bearomorphism

Copy link
Copy Markdown
Collaborator

@Lee-W please try #1513

@Lee-W

Lee-W commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

I'm a damn idoit 🤦‍♂️

@Lee-W

Lee-W commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

@bearomorphism I think i get it restored and push to this one

@bearomorphism

bearomorphism commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

@bearomorphism

Copy link
Copy Markdown
Collaborator

This is also easy to review, thanks

@Lee-W

Lee-W commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

I'm going to release it tonight if no one objects

@Lee-W Lee-W merged commit 8675c28 into master Jun 9, 2025
18 checks passed
@Lee-W Lee-W deleted the refactors branch June 9, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants