Skip to content

Commit 448a522

Browse files
committed
Fix reviewer feedback: skeleton CSS & JSX issues
1 parent 0f7112e commit 448a522

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/pages/Weather.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,17 +98,17 @@ export default function Weather() {
9898
<Card title={`Current in ${city}`} aria-label={`Current weather in ${city}`}>
9999
<div aria-label={loading ? "Temperature loading" : `Temperature: ${displayTemp(Number(current?.temp_C))}°${unit}`}>
100100
Temperature:{" "}
101-
{loading || !current?.temp_C ? <Skeleton height="14px" width="38px" aria-label="Temperature loading" /> : `${displayTemp(Number(current.temp_C))}°${unit}`}
101+
{loading || !current?.temp_C ? <Skeleton height="15px" width="38px" aria-label="Temperature loading" /> : `${displayTemp(Number(current.temp_C))}°${unit}`}
102102
</div>
103103

104104
<div aria-label={loading ? "Humidity loading" : `Humidity: ${current?.humidity}%`}>
105105
Humidity:{" "}
106-
{loading || !current?.humidity ? <Skeleton height="14px" width="35px" aria-label="Humidity loading" /> : `${current.humidity}%`}
106+
{loading || !current?.humidity ? <Skeleton height="15px" width="35px" aria-label="Humidity loading" /> : `${current.humidity}%`}
107107
</div>
108108

109109
<div aria-label={loading ? "Weather description loading" : `Description: ${current?.weatherDesc?.[0]?.value}`}>
110110
Desc:{" "}
111-
{loading || !current?.weatherDesc?.[0]?.value ? <Skeleton height="14px" width="80px" aria-label="Description loading" /> : current.weatherDesc[0].value}
111+
{loading || !current?.weatherDesc?.[0]?.value ? <Skeleton height="15px" width="80px" aria-label="Description loading" /> : current.weatherDesc[0].value}
112112
</div>
113113
</Card>
114114

src/styles.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ blockquote {
229229
height: 16px;
230230
vertical-align: middle;
231231
margin-left: 5px;
232-
233232
}
234233

235234
@keyframes skeleton-loading {

0 commit comments

Comments
 (0)