Skip to content

Commit 1bf7449

Browse files
arimu1mr-c
authored andcommitted
ci: don't fail CI when Codecov upload fails on fork PRs
The three Codecov upload steps use fail_ci_if_error: true with a token-gated upload (CODECOV_TOKEN). GitHub Actions withholds secrets from pull requests opened from forks, so the upload step fails and turns the whole CI run red for external contributors, regardless of whether their actual changes pass. This restores the behaviour intentionally set in #1857 ("keep running even if codecov upload fails"), which was reverted by fe1e8a9 ("Fix codecov v4 configuration"). Coverage uploads from trusted (non-fork) runs still happen; they just no longer hard-fail CI.
1 parent 8949fc2 commit 1bf7449

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/ci-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
if: ${{ matrix.step == 'unit' }}
9090
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
9191
with:
92-
fail_ci_if_error: true
92+
fail_ci_if_error: false
9393
env:
9494
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
9595

@@ -231,7 +231,7 @@ jobs:
231231
- name: Upload coverage to Codecov
232232
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
233233
with:
234-
fail_ci_if_error: true
234+
fail_ci_if_error: false
235235
env:
236236
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
237237
release_test:
@@ -320,6 +320,6 @@ jobs:
320320
- name: Upload coverage to Codecov
321321
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
322322
with:
323-
fail_ci_if_error: true
323+
fail_ci_if_error: false
324324
env:
325325
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

0 commit comments

Comments
 (0)