ci: don't fail CI when Codecov upload fails on fork PRs#2294
Closed
arimu1 wants to merge 1 commit into
Closed
Conversation
The three Codecov upload steps use fail_ci_if_error: true with a token-gated upload (CODECOV_TOKEN). GitHub Actions withholds secrets from pull requests opened from forks, so the upload step fails and turns the whole CI run red for external contributors, regardless of whether their actual changes pass. This restores the behaviour intentionally set in common-workflow-language#1857 ("keep running even if codecov upload fails"), which was reverted by fe1e8a9 ("Fix codecov v4 configuration"). Coverage uploads from trusted (non-fork) runs still happen; they just no longer hard-fail CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
+ Coverage 85.10% 85.18% +0.08%
==========================================
Files 46 46
Lines 8591 8591
Branches 2011 2011
==========================================
+ Hits 7311 7318 +7
+ Misses 813 807 -6
+ Partials 467 466 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three Codecov upload steps use fail_ci_if_error: true with a token-gated upload (CODECOV_TOKEN). GitHub Actions withholds secrets from pull requests opened from forks, so the upload step fails and turns the whole CI run red for external contributors, regardless of whether their actual changes pass.
This restores the behaviour intentionally set in #1857 ("keep running even if codecov upload fails"), which was reverted by fe1e8a9 ("Fix codecov v4 configuration"). Coverage uploads from trusted (non-fork) runs still happen; they just no longer hard-fail CI.