Add type hints to parsers#993
Draft
GlassOfWhiskey wants to merge 1 commit into
Draft
Conversation
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
from
0e71603 to
63fea3e
Compare
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
9 times, most recently
from
ddb56f1 to
b7800c2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 71.58% 71.55% -0.04%
==========================================
Files 53 53
Lines 9912 9978 +66
Branches 2058 2057 -1
==========================================
+ Hits 7096 7140 +44
- Misses 2264 2290 +26
+ Partials 552 548 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
2 times, most recently
from
33bb828 to
a8947d0
Compare
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
6 times, most recently
from
4f2c146 to
cc5d220
Compare
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
4 times, most recently
from
114f0fd to
3883246
Compare
GlassOfWhiskey
force-pushed
the
typed-python-parsers
branch
from
3883246 to
09cfc31
Compare
mr-c
reviewed
Jun 30, 2026
|
|
||
| ext = ", ".join(parents) if parents else "Saveable" | ||
| self.out.write( | ||
| fmt(f"@mypyc_attr(native_class=True)\nclass {classname}({ext}):\n pass", 0)[:-9] |
Member
There was a problem hiding this comment.
Why @mypyc_attr(native_class=True)?
Contributor
Author
There was a problem hiding this comment.
To ensure it is actually compiled succesfully by mypyc, and to intercept potential regressions in the future
Member
There was a problem hiding this comment.
I recommend @mypyc_attr(native_class=True, allow_interpreted_subclasses=True) to allow for subclassing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables type hints within Python generated parsers. by refactoring how the codegen logic handles instance types. Results are fully-typed Python objects ready to be compiled with
mypyc.