Conversation
sebastian-nagel
requested changes
Dec 23, 2025
sebastian-nagel
left a comment
There was a problem hiding this comment.
Hi Luca, looks good. The validation for record-at-time compression might be more reliable by extending jwarc's WARC reader or by integrating the validation there.
Collaborator
Author
|
Considering the above comments and the latest discussions with @sebastian-nagel and @wumpus I've switched back to demonstrating the random access using JWARC. |
# Conflicts: # Makefile # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implement Task 5 (wreck the warc).
The task mimic the python whirlwind tour.Implement validation of wrongly compressed gzip through access rather than by checking the gzip upfront - the only right approach is anyway to iterate over itOutput as comment.
Notes & open questions
The way the gzip compression is detected is by checking the extension, which is a simple approachIt seems this functionality is not available in JWARC, we should consider pushing it upstream in future when it's more consolidatedWe could implement a more straightforward validation extending the JWARC Reader cf