Fix: Add errno check to strtol for detecting out-of-range width values#615
Open
ismaileneskucuk wants to merge 2 commits into
Open
Fix: Add errno check to strtol for detecting out-of-range width values#615ismaileneskucuk wants to merge 2 commits into
ismaileneskucuk wants to merge 2 commits into
Conversation
Contributor
|
In addition, you have to check that the input string isn't empty, in which case |
Contributor
Author
|
Updated the logic to use Also added a check to reject Let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #614
Added errno = 0 before parsing and an ERANGE check afterwards to safely exit with an error message when out-of-range width values are provided.