Added missing <iterator> includes.

arobenko · arobenko · commit 05ae5cd73c93 · 2025-12-19T08:04:40.000+10:00
diff --git a/include/comms/field/adapter/AvailableLength.h b/include/comms/field/adapter/AvailableLength.h
@@ -16,6 +16,7 @@
 #include "comms/util/type_traits.h"
 
 #include <algorithm>
+#include <iterator>
 #include <limits>
 #include <type_traits>
 
diff --git a/include/comms/field/adapter/SequenceSerLengthFieldPrefix.h b/include/comms/field/adapter/SequenceSerLengthFieldPrefix.h
@@ -10,6 +10,8 @@
 #include "comms/Assert.h"
 #include "comms/ErrorStatus.h"
 
+#include <iterator>
+
 namespace comms
 {
 
diff --git a/include/comms/field/adapter/SequenceSizeFieldPrefix.h b/include/comms/field/adapter/SequenceSizeFieldPrefix.h
@@ -10,6 +10,8 @@
 #include "comms/Assert.h"
 #include "comms/ErrorStatus.h"
 
+#include <iterator>
+
 namespace comms
 {
 
diff --git a/include/comms/field/adapter/SequenceTerminationFieldSuffix.h b/include/comms/field/adapter/SequenceTerminationFieldSuffix.h
@@ -12,6 +12,8 @@
 #include "comms/ErrorStatus.h"
 #include "comms/util/type_traits.h"
 
+#include <iterator>
+
 namespace comms
 {
 
diff --git a/include/comms/field/basic/ArrayList.h b/include/comms/field/basic/ArrayList.h
@@ -24,6 +24,7 @@
 #include "comms/util/type_traits.h"
 
 #include <algorithm>
+#include <iterator>
 #include <limits>
 #include <numeric>
 #include <type_traits>
diff --git a/include/comms/field/details/FieldOpHelpers.h b/include/comms/field/details/FieldOpHelpers.h
@@ -11,6 +11,7 @@
 #include "comms/ErrorStatus.h"
 
 #include <cstdint>
+#include <iterator>
 #include <limits>
 #include <type_traits>
 
diff --git a/include/comms/frame/MsgIdLayer.h b/include/comms/frame/MsgIdLayer.h
@@ -24,6 +24,7 @@
 
 #include <algorithm>
 #include <array>
+#include <iterator>
 #include <limits>
 #include <tuple>
 #include <utility>
diff --git a/include/comms/frame/TransportValueLayer.h b/include/comms/frame/TransportValueLayer.h
@@ -17,6 +17,8 @@
 #include "comms/frame/details/TransportValueLayerBase.h"
 #include "comms/util/type_traits.h"
 
+#include <iterator>
+
 COMMS_MSVC_WARNING_PUSH
 COMMS_MSVC_WARNING_DISABLE(4189) // Disable erroneous initialized but not referenced variable warning
 
diff --git a/test/ChecksumLayer.th b/test/ChecksumLayer.th
@@ -5,20 +5,20 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-#include <iostream>
-#include <iomanip>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+#include <iostream>
+#include <iomanip>
+
 class ChecksumLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/ChecksumPrefixLayer.th b/test/ChecksumPrefixLayer.th
@@ -5,20 +5,20 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-#include <iostream>
-#include <iomanip>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+#include <iostream>
+#include <iomanip>
+
 class ChecksumPrefixLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/CommsTestCommon.h b/test/CommsTestCommon.h
@@ -7,13 +7,13 @@
 
 #pragma once
 
+#include "comms/comms.h"
+
 #include <tuple>
 #include <vector>
 #include <iterator>
 #include <iostream>
 
-#include "comms/comms.h"
-
 static_assert(0U < comms::version(), "Invalid version definition");
 static_assert(0U < COMMS_MAKE_VERSION(0, 29, 0), "Invalid version definition");
 
diff --git a/test/CustomChecksumLayer.th b/test/CustomChecksumLayer.th
@@ -5,19 +5,19 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+#include "comms/comms.h"
+#include "comms/frame/checksum/BasicSum.h"
+#include "comms/frame/checksum/Crc.h"
+
+#include "CommsTestCommon.h"
+
 #include <cstdint>
 #include <cstddef>
 #include <algorithm>
 #include <iterator>
 #include <iostream>
 #include <iomanip>
 
-#include "comms/comms.h"
-#include "comms/frame/checksum/BasicSum.h"
-#include "comms/frame/checksum/Crc.h"
-
-#include "CommsTestCommon.h"
-
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
diff --git a/test/CustomChecksumPrefixLayer.th b/test/CustomChecksumPrefixLayer.th
@@ -5,13 +5,6 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-#include <iostream>
-#include <iomanip>
-
 #include "comms/comms.h"
 #include "comms/frame/checksum/BasicSum.h"
 #include "comms/frame/checksum/Crc.h"
@@ -22,6 +15,13 @@ CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+#include <iostream>
+#include <iomanip>
+
 class CustomChecksumPrefixLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/CustomMsgIdLayer.th b/test/CustomMsgIdLayer.th
@@ -5,18 +5,18 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+
 class CustomMsgIdLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/CustomMsgSizeLayer.th b/test/CustomMsgSizeLayer.th
@@ -5,18 +5,18 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+
 class CustomPostIdMsgSizeLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/CustomSyncPrefixLayer.th b/test/CustomSyncPrefixLayer.th
@@ -5,18 +5,18 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+
 class CustomSyncPrefixLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/CustomTransportValueLayer.th b/test/CustomTransportValueLayer.th
@@ -5,18 +5,18 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+
 class CustomTransportValueLayerTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/Dispatch.th b/test/Dispatch.th
@@ -5,11 +5,6 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <algorithm>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "comms/dispatch.h"
 #include "comms/process.h"
@@ -19,6 +14,11 @@ CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <algorithm>
+#include <iterator>
+
 class DispatchTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/Fields.th b/test/Fields.th
@@ -5,6 +5,13 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+#include "comms/comms.h"
+#include "CommsTestCommon.h"
+
+CC_DISABLE_WARNINGS()
+#include "cxxtest/TestSuite.h"
+CC_ENABLE_WARNINGS()
+
 #include <cstdint>
 #include <algorithm>
 #include <limits>
@@ -13,13 +20,6 @@
 #include <ratio>
 #include <type_traits>
 
-#include "comms/comms.h"
-#include "CommsTestCommon.h"
-
-CC_DISABLE_WARNINGS()
-#include "cxxtest/TestSuite.h"
-CC_ENABLE_WARNINGS()
-
 static_assert(comms::util::detect::hasClearFunc<std::string>(), "Invalid function presence detection");
 static_assert(comms::util::detect::hasClearFunc<std::vector<std::uint8_t> >(), "Invalid function presence detection");
 static_assert(comms::util::detect::hasClearFunc<comms::util::StaticString<5> >(), "Invalid function presence detection");
diff --git a/test/Fields2.th b/test/Fields2.th
@@ -5,20 +5,20 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <algorithm>
-#include <limits>
-#include <memory>
-#include <iterator>
-#include <type_traits>
-
 #include "comms/comms.h"
 #include "comms/options.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <algorithm>
+#include <limits>
+#include <memory>
+#include <iterator>
+#include <type_traits>
+
 class FieldsTestSuite2 : public CxxTest::TestSuite
 {
 public:
diff --git a/test/Message.th b/test/Message.th
@@ -5,18 +5,18 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-#include <cstdint>
-#include <cstddef>
-#include <memory>
-#include <iterator>
-
 #include "comms/comms.h"
 #include "CommsTestCommon.h"
 
 CC_DISABLE_WARNINGS()
 #include "cxxtest/TestSuite.h"
 CC_ENABLE_WARNINGS()
 
+#include <cstdint>
+#include <cstddef>
+#include <memory>
+#include <iterator>
+
 class MessageTestSuite : public CxxTest::TestSuite
 {
 public:
diff --git a/test/MsgDataLayer.th b/test/MsgDataLayer.th
diff --git a/test/MsgFactory.th b/test/MsgFactory.th
diff --git a/test/MsgIdLayer.th b/test/MsgIdLayer.th
diff --git a/test/MsgSizeLayer.th b/test/MsgSizeLayer.th
diff --git a/test/SyncPrefixLayer.th b/test/SyncPrefixLayer.th
diff --git a/test/SyncSuffixLayer.th b/test/SyncSuffixLayer.th
diff --git a/test/TransportValueLayer.th b/test/TransportValueLayer.th

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@`
`10`	`10`	`#include "comms/Assert.h"`
`11`	`11`	`#include "comms/ErrorStatus.h"`
`12`	`12`
	`13`	`+#include <iterator>`
	`14`	`+`
`13`	`15`	`namespace comms`
`14`	`16`	`{`
`15`	`17`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@`
`12`	`12`	`#include "comms/ErrorStatus.h"`
`13`	`13`	`#include "comms/util/type_traits.h"`
`14`	`14`
	`15`	`+#include <iterator>`
	`16`	`+`
`15`	`17`	`namespace comms`
`16`	`18`	`{`
`17`	`19`