Compilation warning on sign-conversion. See issue #6 on github.

Author: arobenko

include/comms/field/adapter/SequenceTerminationFieldSuffix.h

@@ -163,13 +163,16 @@ class SequenceTerminationFieldSuffix : public TBase
     template <typename TIter, typename... TParams>
     comms::ErrorStatus readInternal(TIter& iter, std::size_t len, RawDataTag<TParams...>)
     {
+        using IterType = typename std::decay<decltype(iter)>::type;
+        using DiffType = typename std::iterator_traits<IterType>::difference_type;
+
         std::size_t consumed = 0U;
         std::size_t termFieldLen = 0U;
         while (consumed < len) {
-            auto iterCpy = iter + consumed;
+            auto iterCpy = iter + static_cast<DiffType>(consumed);
             auto es = m_termField.read(iterCpy, len - consumed);
             if (es == comms::ErrorStatus::Success) {
-                termFieldLen = static_cast<std::size_t>(std::distance(iter + consumed, iterCpy));
+                termFieldLen = static_cast<std::size_t>(std::distance(iter + static_cast<DiffType>(consumed), iterCpy));
                 break;
             }
 

include/comms/field/basic/ArrayList.h

@@ -673,7 +673,9 @@ class ArrayList :
     template <typename TIter, typename... TParams>
     ErrorStatus readInternal(TIter& iter, std::size_t len, RawDataTag<TParams...>)
     {
-        comms::util::assign(value(), iter, iter + std::min(len, comms::util::maxSizeOf(value())));
+        using IterType = typename std::decay<decltype(iter)>::type;
+        using DiffType = typename std::iterator_traits<IterType>::difference_type;
+        comms::util::assign(value(), iter, iter + static_cast<DiffType>(std::min(len, comms::util::maxSizeOf(value()))));
         std::advance(iter, len);
         return ErrorStatus::Success;
     }