EIP1-13829 Deploy from main without using Github environment#11
Draft
StephenPenney wants to merge 4 commits into
Draft
EIP1-13829 Deploy from main without using Github environment#11StephenPenney wants to merge 4 commits into
StephenPenney wants to merge 4 commits into
Conversation
Also add todos where could switch to read only IAM Github role
StephenPenney
force-pushed
the
eip1-13829-use-read-only-rule-and-avoid-dev2-environment-on-main
branch
from
1036d56 to
c11702a
Compare
emisto3
approved these changes
May 15, 2026
Contributor
emisto3
left a comment
emisto3
left a comment
There was a problem hiding this comment.
lgtm :) small comments only
| bump-and-push-tag: | ||
| needs: get-latest-tag | ||
| uses: communitiesuk/eip-ero-shared-workflows/.github/workflows/bump-and-push-tag.yml@main | ||
| uses: communitiesuk/eip-ero-shared-workflows/.github/workflows/bump-and-push-tag.yml@eip1-13829-use-read-only-rule-and-avoid-dev2-environment-on-main |
Contributor
There was a problem hiding this comment.
Is this (and the others) going to be updated to main before merging?
Author
There was a problem hiding this comment.
Yes. My plan was to get this draft reviewed first to make sure the code is okay before running it on Print API then merge (after changing these back to main) once confirm it all works
| Note that this is a repository secret, not an environment secret. | ||
|
|
||
| The repositories should also have a repository secret `PREPROD_READ_ONLY_IAM_GITHUB_ROLE_ARN` | ||
| set to the IAM role ARN of a read only GitHub role in the AWS preprod account. |
Contributor
There was a problem hiding this comment.
Feel free to ignore but I wonder if making it clear what this is used for would make this clearer?
Suggested change
| set to the IAM role ARN of a read only GitHub role in the AWS preprod account. | |
| set to the IAM role ARN of a read only GitHub role in the AWS preprod account. This is used for actions triggered on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Deploy from main without using Github environment
Also add todos where could switch to read only IAM Github role
Issue ticket number and link
https://mhclgdigital.atlassian.net/browse/EIP1-13829
Checklist before requesting a review
Tick all those which are done
Replace check box with ❌ if the step is not relevant for this PR