EPBR-9262 Updates to action plan request return format for Scottish endpoint from view model update

Author: emollett

Gemfile

@@ -23,7 +23,7 @@ gem "archive-zip"
 gem "aws-sdk-s3", "= 1.209.0"
 gem "csv", "~> 3.3"
 gem "epb-auth-tools", "~> 1.1.0"
-gem "epb_view_models", "~> 2.2.4"
+gem "epb_view_models", "~> 2.2.5"
 gem "geocoder", "~> 1.8.6"
 gem "json-schema", "~> 6.0"
 gem "namecase", "~> 2.0"

Gemfile.lock

@@ -64,7 +64,7 @@ GEM
     epb-auth-tools (1.1.0)
       jwt (~> 2.3)
       oauth2 (>= 1.4, < 3.0)
-    epb_view_models (2.2.4)
+    epb_view_models (2.2.5)
       nokogiri (~> 1.16)
       zeitwerk (~> 2.6)
     faraday (2.14.0)
@@ -283,7 +283,7 @@ DEPENDENCIES
   csv (~> 3.3)
   database_cleaner
   epb-auth-tools (~> 1.1.0)
-  epb_view_models (~> 2.2.4)
+  epb_view_models (~> 2.2.5)
   geocoder (~> 1.8.6)
   json-schema (~> 6.0)
   mock_redis (~> 0.52)

spec/acceptance/scotland-schema/scotland_certificate_summary_spec.rb

@@ -510,15 +510,17 @@
                                  registeredBy: { name: "test scheme", schemeId: scheme_id } },
                               ownerCommissionReport: "Y",
                               delegatedPersonCommissionReport: "N",
-                              propertyTypeShortDescription: "General Industrial",
-                              propertyTypeLongDescription: "B2 to B7 General Industrial and Special Industrial Groups",
+                              propertyType: {
+                                propertyTypeShortDescription: "General Industrial",
+                                propertyTypeLongDescription: "B2 to B7 General Industrial and Special Industrial Groups",
+                              },
                               buildingImprovements: "N",
                               operationalRatings: "Y",
                               dec: "N",
                               plannedCompletionDate: "2028-12-12",
                               actualCompletionDate: nil,
-                              targetEmissionSavings: "1.61",
-                              targetEnergySavings: "10.11",
+                              targetEmissionSavings: 1.61,
+                              targetEnergySavings: 10.11,
                               acceptPrescriptiveImprovements: "Y",
                               prescriptiveImprovements:
                                [{ measureDescriptionShort: "Central time heating control", measureDescriptionLong: nil, measureValid: "N", measureType: nil },