Scotland end to end test#737
Open
Christine-horrocks wants to merge 24 commits into
Open
Conversation
…assessments to the Scotland schema Updated the foreign keys in the Scotland schema tables to point to tables in the correct schema (not always the Scotland schema) Gone through the lodge_ assessment use case. I have added in an is_scottish flag which can then be passed into the dependant methods and gateways. I have only altered things which are necessary for migration not lodgement. I have added #TODO flags where things will need to be changed later. In the gateways I have added the is_scottish flag which then allows the gateway to swap between schemas. I have added tests for Scottish assessments in the gateway unit tests and end to end acceptance tests for lodging a Scottish assessment.
Adding an is_scottish flag to the even broadcaster in the lodge assessment file to be passed through to the notify new assessment to data warehouse use case. This means we can prevent scottish assessments being added to the queue to go to the data warehouse.
Where the is_scottish param is added to gateways it has been made a named param. Test have also been added to cover get canonical use case and assessment address id gateway tests to fix ever passing test.
…usion due to repeated rrn
…est and update label
…missing green deal plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.