Not a PR, notes on seeding NFT#1334
Draft
JasminConterioSW wants to merge 4 commits into
Draft
Conversation
| <method v="2"> | ||
| <option name="RunConfigurationTask" enabled="true" run_configuration_name="local_resources_up" run_configuration_type="docker-deploy" /> | ||
| <option name="Make" enabled="true" /> | ||
| <option name="RunConfigurationTask" enabled="true" run_configuration_name="flywayClean-local-except-address" run_configuration_type="GradleRunConfiguration" /> |
Contributor
Author
There was a problem hiding this comment.
Make sure it doesn't try to wipe the database before running the task!
Might need to remove flywayClean-local-except-address from the run configuration locally from the "Before launch" section
Comment on lines
+262
to
+270
| // Flush any remaining batched items if we ran out of landlords before reaching NUM_OF_PROPERTIES | ||
| if (newPropertyRegistrations > 0 && newPropertyRegistrations % BATCH_SIZE != 0) { | ||
| registrationNumberStmt.executeBatch() | ||
| licenceStmt.executeBatch() | ||
| propertyOwnershipStmt.executeBatch() | ||
| propertyComplianceStmt.executeBatch() | ||
| reminderEmailSentStmt.executeBatch() | ||
| savedJourneyStateStmt.executeBatch() | ||
| incompletePropertyStmt.executeBatch() |
Contributor
Author
There was a problem hiding this comment.
This was copilot, it may or may not be working....
It won't necessarily add all the properties if it runs out of landlords first (it just adds properties when it's adding landlords)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number
PDJB-NONE
Goal of change
Seed a few hundred records for pen testing, including a load in a particular LC
Description of main change(s)
Running it:
Anything you'd like to highlight to the reviewer?
Checklist