Skip to content

PDJB-792: Add feature flag for compliance actions page#1358

Merged
samyou-softwire merged 9 commits into
mainfrom
feat/PDJB-792-1-add-feature-flag
May 21, 2026
Merged

PDJB-792: Add feature flag for compliance actions page#1358
samyou-softwire merged 9 commits into
mainfrom
feat/PDJB-792-1-add-feature-flag

Conversation

@samyou-softwire

@samyou-softwire samyou-softwire commented May 19, 2026

Copy link
Copy Markdown
Contributor

Ticket number

PDJB-792

Goal of change

adds feature flag and skeleton new view for the compliance actions page

Description of main change(s)

  • adds the feature flag that will toggle if we use the new redesign
  • adds a release as this is the first feature flag in the release
  • adds a copy of the compliance actions page that we can update independent of the old compliance actions page
  • adds a test to verify we get the correct page back

Anything you'd like to highlight to the reviewer?

making this a sep PR so we can get this release registered in the code early so other people can use this

may also split the compliance actions page redesign into smaller tickets that can be worked on in parallel

the actual redesign is TODO. both templates should be identical

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added (no UI change)
  • Controller tests for any new endpoints, including testing the relevant permissions
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here (there is one, but this'll be addressed when we progress with any redesign)
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket) (no QA thus far)

@samyou-softwire samyou-softwire self-assigned this May 19, 2026
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-792-1-add-feature-flag branch 3 times, most recently from bbdc95f to a0004b0 Compare May 19, 2026 16:47
@samyou-softwire samyou-softwire marked this pull request as ready for review May 20, 2026 08:10
adds private beta release #2 to releases
duplicate of the old one for now

allows for these two to diverge without lots of difficult branching and cleanup later
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-792-1-add-feature-flag branch from a0004b0 to c19222b Compare May 20, 2026 08:16
Comment thread src/main/resources/application-local.yml Outdated

@TomHanmer29 TomHanmer29 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing about the if is the only real comment, the rest is all very minor :) Looks good!

Comment thread src/main/kotlin/uk/gov/communities/prsdb/webapp/constants/FeatureFlagNames.kt Outdated
Comment thread src/main/kotlin/uk/gov/communities/prsdb/webapp/controllers/LandlordController.kt Outdated
Comment thread src/main/resources/application-local.yml Outdated
@samyou-softwire

Copy link
Copy Markdown
Contributor Author

I've also renamed the 'old' and 'new' templates to make the new one specific to this redesign

redundant use

specify which redesign
makes it so we wont have collisions on the next redesign
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-792-1-add-feature-flag branch from 43848b7 to 12030f6 Compare May 21, 2026 10:44
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-792-1-add-feature-flag branch from 12030f6 to 66c1ca2 Compare May 21, 2026 10:44

@TomHanmer29 TomHanmer29 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samyou-softwire samyou-softwire added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 8f04ea1 May 21, 2026
8 checks passed
@samyou-softwire samyou-softwire deleted the feat/PDJB-792-1-add-feature-flag branch May 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants