Fix/pdjb 883 remove sysop dashboard button#1359
Merged
JasminConterioSW merged 3 commits intoMay 20, 2026
Merged
Conversation
samyou-softwire
approved these changes
May 20, 2026
Contributor
samyou-softwire
left a comment
There was a problem hiding this comment.
LGTM, after removing that attribute
it's a little sad that we'll need to add this template back if we ever add in a disabled button somewhere, though suppose it's better than having orphaned code that'll likely fall out of style
samyou-softwire
approved these changes
May 20, 2026
Contributor
Author
The current pattern is to just not add a button if we don't have somewhere to go yet rather than adding a disabled button (although that might change of course!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number
PDJB-883
Goal of change
Remove disabled "dashboard" button from lc admin invitation confirmation page
Description of main change(s)
Removed the button, and the fragment that created it (not used anywhere else)
Before:

After:

Anything you'd like to highlight to the reviewer?
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
mention that here