Skip to content

Fix/pdjb 883 remove sysop dashboard button#1359

Merged
JasminConterioSW merged 3 commits into
mainfrom
fix/PDJB-883-remove-sysop-dashboard-button
May 20, 2026
Merged

Fix/pdjb 883 remove sysop dashboard button#1359
JasminConterioSW merged 3 commits into
mainfrom
fix/PDJB-883-remove-sysop-dashboard-button

Conversation

@JasminConterioSW
Copy link
Copy Markdown
Contributor

@JasminConterioSW JasminConterioSW commented May 20, 2026

Ticket number

PDJB-883

Goal of change

Remove disabled "dashboard" button from lc admin invitation confirmation page

Description of main change(s)

Removed the button, and the fragment that created it (not used anywhere else)

Before:
image

After:
image

Anything you'd like to highlight to the reviewer?

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Test suite has been run in full locally and is passing
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)

Copy link
Copy Markdown
Contributor

@samyou-softwire samyou-softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after removing that attribute

it's a little sad that we'll need to add this template back if we ever add in a disabled button somewhere, though suppose it's better than having orphaned code that'll likely fall out of style

@JasminConterioSW
Copy link
Copy Markdown
Contributor Author

LGTM, after removing that attribute

it's a little sad that we'll need to add this template back if we ever add in a disabled button somewhere, though suppose it's better than having orphaned code that'll likely fall out of style

The current pattern is to just not add a button if we don't have somewhere to go yet rather than adding a disabled button (although that might change of course!)

@JasminConterioSW JasminConterioSW added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 518032c May 20, 2026
8 checks passed
@JasminConterioSW JasminConterioSW deleted the fix/PDJB-883-remove-sysop-dashboard-button branch May 20, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants