PDJB-912: Add back link to privacy notice pages#1361
Merged
Conversation
Bill-Haigh
marked this pull request as ready for review
May 20, 2026 15:41
samyou-softwire
approved these changes
May 21, 2026
samyou-softwire
left a comment
samyou-softwire
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one comment on some out of scope behaviour & the ticket is looking for QA notes.
I notice the run tests pipeline never reported its status. are you able to rerun that pipeline?
…k-link-to-privacy-notice # Conflicts: # src/main/kotlin/uk/gov/communities/prsdb/webapp/controllers/LocalCouncilDashboardController.kt
…rging main PDJB-900 moved the LC dashboard's privacy/renters-rights links into the footer (using the global privacyUrl from GlobalModelAttributes, which already wraps with overrideBackLinkForUrl). The privacyNoticeUrl model attribute on LocalCouncilDashboardController is no longer referenced by any template, and the integration test that clicked the dashboard's old privacyNoticeLink can't be reproduced via the footer at the webapp test layer (the /privacy-notice -> /local-council/privacy-notice rewrite happens in infra). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…y-notice Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number
PDJB-912
Goal of change
Add a GOV.UK back link to the standalone privacy notice pages so users can easily return to where they came from, without showing a back link when the page is opened in a new tab.
Description of main change(s)
BackLinkInterceptor/BackUrlStorageServicemechanism already used by the cookies page: the link URL carries awithBackUrl=<key>query param, the interceptor populates thebackUrlmodel attribute, and the existingbackLinkfragment renders the link only when that attribute is setAnything you'd like to highlight to the reviewer?
The in-journey privacy notice form pages (registration journeys) are intentionally out of scope — those journeys link to the standalone page with
target="_blank"(opens in new tab), and the requirement is explicitly "back link only when not opening in a new tab".Checklist