PDJB-1134: Updated error message for missing address line one#1545
PDJB-1134: Updated error message for missing address line one#1545bnjn-mt wants to merge 6 commits into
Conversation
bnjn-mt
changed the title
samyou-softwire
left a comment
samyou-softwire
left a comment
There was a problem hiding this comment.
we should be careful around making these changes - let me know if you want me to post anything on jira on your behalf
| label: Address line 1 | ||
| error: | ||
| missing: 'Enter the first line of an address, typically the building and street' | ||
| missing: 'Enter address line 1, typically the building and street' |
There was a problem hiding this comment.
I think this is a bigger change than we want - looks like this would update the error message everywhere where the manual page is used.
if we're concerned about the error message being inconsistent on the service, we should flag this with design. I can ping them on the ticket if you'd like? I think we should probably use the same error everywhere, probably easiest for the designers of this journey to use the one we use elsewhere
There was a problem hiding this comment.
That makes sense to me. Yes, could you add a comment on the ticket for me? Thanks
There was a problem hiding this comment.
I suspect this is just a mix up from the designers - they did agree that in general we could use our existing validation messages rather than the ones in the designs if they were appropriate for the org landlords work.
There was a problem hiding this comment.
yeah they've agreed to this on jira too. let's leave the error message as-is which matches the rest of the site. I'll approve QA on PDJB-1134 now
Co-authored-by: Samuel Young <samuel.young@softwire.com>
|
It sounds like we've agreed this PR is no longer needed? If so can we close it off please? Thanks both for resolving this |
3 participants
Ticket number
PDJB-1134
Description of main change(s)
• Changes the missing address line 1 error message
• Updates the affected single-page integration test assertions to match