feat: implement disk resize in LXC settings#177
Merged
michelroegl-brunner merged 1 commit intomainfrom Oct 17, 2025
Merged
Conversation
- Add automatic disk resizing when changing LXC disk size in settings - Implement separate modal flow: confirmation -> loading -> result -> settings - Add proper error detection for pct resize command (check both exit code and output) - Add LVM fallback resize method when pct resize fails - Implement configuration rollback on resize failure - Update modal styling to use semantic color classes for proper dark mode support - Add data refresh after result modal close to show updated values - Remove success/error banners from settings modal for cleaner UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automatic disk resizing when changing LXC disk size in the settings modal, along with a complete modal flow redesign and robust error handling.
Features Added
🔧 Disk Resize Functionality
pct resizecommand with LVM fallback (lvresize,resize2fs/xfs_growfs)🎨 Improved Modal Flow
🐛 Enhanced Error Handling
🎨 UI/UX Improvements
Technical Details
Backend Changes (
installedScripts.ts)parseRootfsStorage()helper to parse storage pool and disk IDextractSizeInGB()helper for size conversionresizeDisk()function with proper error detectiontryLVMResize()fallback methodFrontend Changes (
LXCSettingsModal.tsx)Error Detection Fix
The main bug fix addresses the issue where
pct resizereturns exit code 0 even when it fails with "Insufficient free space". The solution checks both:Testing