Fix: Include 'New' scripts in Download All Filtered when no filters are active#278
Merged
michelroegl-brunner merged 1 commit intomainfrom Nov 7, 2025
Merged
Fix: Include 'New' scripts in Download All Filtered when no filters are active#278michelroegl-brunner merged 1 commit intomainfrom
michelroegl-brunner merged 1 commit intomainfrom
Conversation
…re active - Modified handleDownloadAllFiltered to combine filteredScripts and newestScripts when no filters are active - Ensures all scripts including those in the 'Newest Scripts' carousel are downloaded - Maintains existing behavior when filters are active - Fixes issue where 'New' scripts were excluded from downloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When no filters are active, clicking 'Download All Filtered' only downloads scripts from the lower section (main grid) and excludes scripts from the 'Newest Scripts' carousel.
Solution
Modified
handleDownloadAllFilteredto include all scripts when no filters are active:filteredScriptsandnewestScripts(deduplicated by slug)filteredScriptsas before (maintains existing behavior)Changes
handleDownloadAllFilteredinScriptsGrid.tsxto check if filters are activeTesting