Fix x button vertical centering in filter scripts search bar#282
Merged
michelroegl-brunner merged 1 commit intomainfrom Nov 7, 2025
Merged
Fix x button vertical centering in filter scripts search bar#282michelroegl-brunner merged 1 commit intomainfrom
michelroegl-brunner merged 1 commit intomainfrom
Conversation
- Removed size='icon' constraint that limited button height - Changed positioning to use inset-y-0 with h-full to match input field height - Added flex items-center justify-center for proper icon centering - Fixes hover background height mismatch between light and dark themes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
size='icon'constraint that was limiting button height to 36pxinset-y-0withh-fullto match the full input field heightflex items-center justify-centerfor proper icon centering within the buttonFixes
Testing