Skip to content

feat: Add delete script functionality#283

Merged
michelroegl-brunner merged 1 commit intomainfrom
feat/delete_downloaded_scripts
Nov 7, 2025
Merged

feat: Add delete script functionality#283
michelroegl-brunner merged 1 commit intomainfrom
feat/delete_downloaded_scripts

Conversation

@michelroegl-brunner
Copy link
Copy Markdown
Member

This PR adds the ability to delete downloaded script files from the ScriptDetailModal.

Changes

  • Added deleteScript method to ScriptDownloaderService (both TypeScript and JavaScript versions)
  • Added deleteScript API endpoint to scripts router
  • Added delete button to ScriptDetailModal with confirmation modal
  • Uses ConfirmationModal component instead of plain window.confirm
  • Delete button only shows when script files exist locally
  • Includes proper error handling and success/error messages

Testing

  • Delete button appears when script files are downloaded
  • Confirmation modal appears when clicking delete
  • Script files are successfully deleted
  • UI updates after deletion to reflect file removal

- Add deleteScript method to ScriptDownloaderService (both .ts and .js)
- Add deleteScript API endpoint to scripts router
- Add delete button to ScriptDetailModal with confirmation modal
- Use ConfirmationModal component instead of plain window.confirm
- Delete button only shows when script files exist locally
- Includes proper error handling and success/error messages
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner November 7, 2025 12:10
@michelroegl-brunner michelroegl-brunner linked an issue Nov 7, 2025 that may be closed by this pull request
@michelroegl-brunner michelroegl-brunner merged commit 0676772 into main Nov 7, 2025
4 checks passed
@michelroegl-brunner michelroegl-brunner changed the title Add delete script functionality feat: Add delete script functionality Nov 7, 2025
@michelroegl-brunner michelroegl-brunner deleted the feat/delete_downloaded_scripts branch November 13, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't delete downloaded scripts

1 participant