fix: Detect script changes from remote repository to allow Script updates#348
Merged
michelroegl-brunner merged 2 commits intomainfrom Nov 26, 2025
Merged
fix: Detect script changes from remote repository to allow Script updates#348michelroegl-brunner merged 2 commits intomainfrom
michelroegl-brunner merged 2 commits intomainfrom
Conversation
- Add refetchOnMount and staleTime: 0 to compareScriptContent query to bypass React Query cache - Add visible refresh button in script detail modal to manually check for updates - Improve comparison error handling and logging for better debugging - Display error messages in UI when comparison fails - Ensure comparison always checks remote repository when modal opens
tremor021
approved these changes
Nov 26, 2025
michelroegl-brunner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user loads a script from the default repo, it works fine. However, when the script changes in the remote repository (GitHub), the user doesn't get notified and cannot update. This happens because:
compareScriptContentquery is cached by React Query (defaultstaleTime: 30s)Solution
refetchOnMount: trueandstaleTime: 0tocompareScriptContentquery to bypass React Query cacheChanges
src/app/_components/ScriptDetailModal.tsx: Updated query options and added refresh buttonsrc/server/services/scriptDownloader.js: Added comprehensive logging and improved error handling