VM-Core: Update some Functions#15113
Merged
Merged
Conversation
Member
Author
|
@copilot im to lazy, summarize the changes as text |
Contributor
Here’s a plain-text summary of what changed in the last commit:
|
CrazyWolf13
reviewed
Jun 25, 2026
| [[ -n "${_CORE_FUNC_LOADED:-}" ]] && return | ||
| _CORE_FUNC_LOADED=1 | ||
|
|
||
| COMMUNITY_SCRIPTS_URL="${COMMUNITY_SCRIPTS_URL:-https://git.community-scripts.org/community-scripts/ProxmoxVE/raw/branch/main}" |
Member
There was a problem hiding this comment.
why headers from one source and general from our git?
Or is this just a fallback?
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared VM helper library (misc/vm-core.func) to support newer VM creation flows (interactive prompts, storage selection, cloud-init helpers) and to adjust supporting utilities (loading shared functions, curl/error handling, cleanup, and VM description markup). This file is a core dependency for VM scripts (e.g., vm/docker-vm.sh) and affects script startup/validation and error semantics.
Changes:
- Added lazy-loading helpers for API and cloud-init functions, plus many new VM interactive prompt/helpers (VMID, machine type, disk, CPU/RAM, networking, storage selection, disk references).
- Modified error/curl utilities (
silent,curl_handler,__curl_err_handler) and cleanup behavior (spinner stop, temp dir removal). - Updated various URLs and the VM description HTML block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+23
| load_api_functions() { | ||
| if ! declare -f post_to_api_vm >/dev/null 2>&1; then | ||
| source /dev/stdin <<<$(curl -fsSL "$COMMUNITY_SCRIPTS_URL/misc/api.func") | ||
| fi | ||
| } |
Comment on lines
+207
to
+210
| # Source explain_exit_code if needed | ||
| if ! declare -f explain_exit_code >/dev/null 2>&1; then | ||
| source <(curl -fsSL "$COMMUNITY_SCRIPTS_URL/misc/error_handler.func") 2>/dev/null || true | ||
| fi |
Comment on lines
203
to
205
| set -Eeuo pipefail | ||
| trap 'error_handler' ERR | ||
|
|
Comment on lines
334
to
336
| [[ -n "$curl_msg" ]] && printf "%s\n" "$curl_msg" >&2 | ||
| exit "$exit_code" | ||
| exit 1 | ||
| } |
Comment on lines
345
to
351
| if [[ "$(ps -p $$ -o comm=)" != "bash" ]]; then | ||
| clear | ||
| msg_error "Your default shell is currently not set to Bash. To use these scripts, please switch to the Bash shell." | ||
| echo -e "\nExiting..." | ||
| sleep 2 | ||
| exit 103 | ||
| exit | ||
| fi |
Comment on lines
+1049
to
+1052
| if [ -z "$valid_storage" ]; then | ||
| msg_error "Unable to detect a valid storage location." | ||
| exit | ||
| elif [ $((${#storage_menu[@]} / 3)) -eq 1 ]; then |
Comment on lines
261
to
264
| if [[ -z "$url" ]]; then | ||
| msg_error "no valid url or option entered for curl_handler" | ||
| exit 64 | ||
| exit 1 | ||
| fi |
Comment on lines
288
to
293
| curl_stderr=$(</tmp/curl_error.log) | ||
| rm -f /tmp/curl_error.log | ||
| fi | ||
| __curl_err_handler "$exit_code" "$url" "$curl_stderr" | ||
| exit "$exit_code" | ||
| exit 1 # hard exit if exit_code is not 0 | ||
| fi |
Comment on lines
1106
to
1110
| <p style='margin: 16px 0;'> | ||
| <a href='${donate_url}' target='_blank' rel='noopener noreferrer'> | ||
| <img src='https://img.shields.io/badge/❤️-Sponsoring%20%26%20Donations-FF5E5B' alt='Sponsoring and donations' /> | ||
| </a> | ||
| </p> | ||
|
|
||
| <p style='margin: 12px 0;'> | ||
| <a href='${script_url}' target='_blank' rel='noopener noreferrer'> | ||
| <img src='https://img.shields.io/badge/📦-Open%20Script%20Page-00617f' alt='Open script page' /> | ||
| <a href='https://ko-fi.com/community_scripts' target='_blank' rel='noopener noreferrer'> | ||
| <img src='https://img.shields.io/badge/☕-Buy us a coffee-blue' alt='spend Coffee' /> | ||
| </a> | ||
| </p> |
Comment on lines
+781
to
+784
| else | ||
| echo -e "${DISKSIZE}${BOLD}${RD}Invalid Disk Size. Please use a number (e.g., 10 or 10G).${CL}" | ||
| exit_script | ||
| fi |
michelroegl-brunner
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
see summarize here; #15113 (comment)
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.